Skip to content

Commit

Permalink
[Lens] Display the metric title on the dashboard panel (elastic#149662)
Browse files Browse the repository at this point in the history
## Summary

Closes elastic#148563

After this [PR](
elastic#148301) being merged, it will be
easier to add the description info icon and the custom data range to the
new metric. For this reason we decided to also allow the panel title for
now.

On the next minors we are going to hide it from the panel and display
all the aforementioned info on the viz title.
<img width="988" alt="image"
src="https://user-images.githubusercontent.com/17003240/215037834-0f556673-8628-484e-aa32-c34188fc7064.png">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
  • Loading branch information
stratoula authored and kqualters-elastic committed Feb 6, 2023
1 parent 439291c commit 4338938
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,7 @@ describe('metric visualization', () => {

it('implements custom display options', () => {
expect(visualization.getDisplayOptions!()).toEqual({
noPanelTitle: true,
noPanelTitle: false,
noPadding: true,
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ export const getMetricVisualization = ({

getDisplayOptions() {
return {
noPanelTitle: true,
noPanelTitle: false,
noPadding: true,
};
},
Expand Down

0 comments on commit 4338938

Please sign in to comment.