fix(__buffer__): fix how __buffer__ is exposed #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my last PR there's a bug that results in `__buffer.events` to become stale after the first time `flush()` is called. This commit fixes that, and adds tests to verify `flush()` clears the buffer.
|
@wsbrunson @westeezy Quick follow-up fix |
wsbrunson
approved these changes
Mar 8, 2023
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 73.46% 73.82% +0.35%
==========================================
Files 5 5
Lines 147 149 +2
==========================================
+ Hits 108 110 +2
Misses 39 39 ☔ View full report in Codecov by Sentry. |
westeezy
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my last PR #69 there's a bug that results in
__buffer.eventsto become stale after the first timeflush()is called.This doesn't affect any of the core functionality, just how tests are run that use this getter.
This commit fixes that, and adds tests to verify
flush()clears the buffer.