chore(logger): expose logger.__buffer__={}, add tests #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
approved these changes
Mar 6, 2023
|
Whoops put a few comments on dist files. I agree with @wsbrunson we will want to back those out since the publish does it automatically. |
westeezy
reviewed
Mar 6, 2023
westeezy
reviewed
Mar 6, 2023
jamischarles
force-pushed
the
expose-buffers
branch
from
8225b7a
to
badf9ea
Compare
jamischarles
commented
Mar 6, 2023
| 3. Locally merge (or rebase) the upstream branch into your topic branch: `$ git pull upstream && git merge`. | ||
| 4. Push your topic branch up to your fork: `$ git push origin <topic-branch-name>`. | ||
| 5. Open a [Pull Request](https://help.github.com/articles/using-pull-requests) with a clear title and description. | ||
| 1. Don't check in your `./dist` folder. You can use this command to ignore it without modifying the .gitignore file: `git update-index —assume-unchanged dist/*.*` |
There was a problem hiding this comment.
Only change here: Added first line. Updated numbers
|
@westeezy Made the recommended changes |
wsbrunson
approved these changes
Mar 6, 2023
jamischarles
changed the title
wsbrunson
approved these changes
Mar 6, 2023
This commit exposes the private buffers publicly
_buffer={events=[],metrics=[],tracking=[]} on the logger instance.
In `3.x` this was exposed on `$beaver` but was removed in later
versions.
Adding this allows us much greater flexibility in testing as well as
allows consuming libraries to assert that they sent the correct events
to the buffer for logging.
This change also allows us to add a lot more tests easily (code coverage
jumped to 73%).
jamischarles
force-pushed
the
expose-buffers
branch
from
f04bf70
to
cc72c85
Compare
|
All issues resolved. This should be good to go now. Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the private buffers publicly (
__buffer__={events=[],metrics=[],tracking=[]}) on the logger instance.In
3.xthis was exposed on$beaverbut was removed in later versions.Adding this allows us much greater flexibility in testing as well as allows consuming libraries to assert that they sent the correct events to the buffer for logging.
This change also allows us to add a lot more tests easily (code coverage jumped to 73%).
Before:
After:
New test cases added
