Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to vitest #72

Merged
merged 5 commits into from
Mar 14, 2023
Merged

chore: move to vitest #72

merged 5 commits into from
Mar 14, 2023

Conversation

westeezy
Copy link
Contributor

Tasks:

Update Node setup

  • turn off save=false in .npmrc to avoid annoyances
  • add .nvmrc and point to v16

Migrate from Karma -> Vitest

  • Removed sync-browser-mocks in favor of a simple global stub
  • Move tests to vitest runner
  • Colocate test in /src/__tests__

Move Diagrams to Mermaid

  • Moving diagrams from images to mermaid for easier editing later

Update License

  • Match Apache 2 License we use elsewhere

@westeezy
Copy link
Contributor Author

@jamischarles you got me thinking about beaver-logger more so making some updates. Overall plan is to increase test coverage + modernize. We should chat some more soon.

cc @sioked

src/__tests__/test.js Outdated Show resolved Hide resolved
@westeezy westeezy force-pushed the vitest branch 2 times, most recently from 89bff4d to ea40b43 Compare March 13, 2023 21:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (4b988e0) to head (5e61b41).
Report is 18 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #72       +/-   ##
===========================================
+ Coverage   73.82%   87.23%   +13.40%     
===========================================
  Files           5        6        +1     
  Lines         149      564      +415     
===========================================
+ Hits          110      492      +382     
- Misses         39       72       +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@jamischarles jamischarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thx @westeezy for bringing the heathens the gospel of vitest.

@westeezy westeezy changed the title House Keeping and Vitest Migration chore: move to vitest Mar 14, 2023
@westeezy westeezy merged commit 28b9d57 into main Mar 14, 2023
@westeezy westeezy deleted the vitest branch March 14, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants