Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isBrowser() to handle React Native #11

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Update isBrowser() to handle React Native #11

merged 1 commit into from
Oct 6, 2020

Conversation

daniel-shuy
Copy link
Contributor

@daniel-shuy daniel-shuy commented Oct 6, 2020 •
edited
Loading

@daniel-shuy daniel-shuy requested a review from a team as a code owner October 6, 2020 07:30
@daniel-shuy daniel-shuy mentioned this pull request Oct 6, 2020
Closed
@bluepnume bluepnume merged commit f17664f into krakenjs:master Oct 6, 2020
@bluepnume
Copy link
Collaborator

Thanks a mil!

@daniel-shuy daniel-shuy deleted the patch-1 branch October 6, 2020 07:33
@daniel-shuy
Copy link
Contributor Author

daniel-shuy commented Oct 6, 2020 •
edited
Loading

@bluepnume Could you add the hacktoberfest topic to the repository so that the PR will count towards it? (Hacktoberfest has changed their rules to require the repository itself to have the hacktoberfest topic, see Hacktoberfest/hacktoberfest-2020#596)

@bluepnume
Copy link
Collaborator

Absolutely :) Added the topics to both belter and beaver-logger.

@daniel-shuy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-shuy @bluepnume