fix: resolve the promise when component is closed/destroyed (#455)

* fix: resolve the promise when component is closed/destroyed * fix: separate detected close errors to reject promise case
krakenjs · Jun 4, 2024 · b42cc03 · b42cc03
1 parent e4da223
commit b42cc03
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/constants.js b/src/constants.js
@@ -14,7 +14,6 @@ export const COMPONENT_ERROR = {
   COMPONENT_DESTROYED: "Component destroyed",
   COMPONENT_CLOSED: "Component closed",
   WINDOW_CLOSED: "Detected component window close",
-  POPUP_CLOSE: "Detected popup close",
   IFRAME_CLOSE: "Detected iframe close",
 };
 

diff --git a/src/parent/parent.js b/src/parent/parent.js
@@ -753,7 +753,8 @@ export function parentComponent<P, X, C>({
         const error = err || new Error(COMPONENT_ERROR.COMPONENT_DESTROYED);
         if (
           (currentContainer && isElementClosed(currentContainer)) ||
-          error.message === COMPONENT_ERROR.NAVIGATED_AWAY
+          // $FlowFixMe
+          Object.values(COMPONENT_ERROR).includes(error.message)
         ) {
           initPromise.resolve();
         } else {
@@ -883,7 +884,7 @@ export function parentComponent<P, X, C>({
       .then((isClosed) => {
         if (!cancelled) {
           if (context === CONTEXT.POPUP && isClosed) {
-            return close(new Error(COMPONENT_ERROR.POPUP_CLOSE));
+            return close(new Error("Detected popup close"));
           }
 
           const isCurrentContainerClosed: boolean = Boolean(