WIP: #776 - socket_recvfrom / socket_sendto support

[sirsnyder]

Support of socket_recvfrom() and socket_sendto(), equal to php socket API

[dktapps]

this will need a check for win32

[dktapps]

same here

[sirsnyder]

check for win32 added, @dktapps

[dktapps]

I haven't had chance to test this yet, will take a look over the weekend.

[dktapps]

Some issues I picked up on:

• The extension can't be compiled without PHP sockets. Use of PHP_SOCKET_ERROR() makes pthreads dependent on the sockets extension, as does usage of the below functions. Shouldn't that be PTHREADS_SOCKET_ERROR()?

socket.obj : error LNK2019: unresolved external symbol PHP_SOCKET_ERROR referenced in function pthreads_socket_recvfrom
socket.obj : error LNK2019: unresolved external symbol php_set_inet_addr referenced in function pthreads_socket_sendto
socket.obj : error LNK2019: unresolved external symbol php_set_inet6_addr referenced in function pthreads_socket_sendto

• MSVC complains about a bunch of unreferenced variable declarations that should probably be moved under their relevant cases.

ext\pthreads\src\socket.c(827): warning C4101: 'addr6': unreferenced local variable

• sockaddr_un is not defined on Windows, again the declarations could probably be moved under the AF_UNIX cases.

[dktapps]

@sirsnyder I've created a few commits you might be interested in cherry-picking (commits 1a1f562, 60401fe and d644417).

I've tested this and it seems to be working fine with my additional patches, but one problem I did spot:

socket_recvfrom($socket, $buf, 65535, 0, $addr, $port);

works, and I don't have to define $buf, $addr and $port separately (since they are set by socket_recvfrom() by reference), but

$socket->recvfrom($buf, 65535, 0, $addr, $port);

raises TypeErrors (Fatal error: Uncaught TypeError: Argument 1 passed to Socket::recvfrom() must be of the type string, null given), requiring those variables to be separately declared. Maybe consider allowing the reference parameters to be nullable.

[dktapps]

Also, I haven't tested IPv6 or Unix socket yet.

[dktapps]

@sirsnyder please also take a look at pmmp/ext-pmmpthread@27ee665 and pmmp/ext-pmmpthread@2300bcc

[dktapps]

shouldn't this be zend_string_free()? (it is also the same in PHP sockets though)

[sirsnyder]

Yes, you're right. This should be ```zend_string_free()``, changed.

[sirsnyder]

Thanks for your commits @dktapps! Would you report the efree/zend_string_free issue to php/php-src? Otherwise I would do that.

[dktapps]

@sirsnyder reported, thanks.

[dktapps]

This is valid if compiled with --enable-ipv6. The AppVeyor configure options might need some adjustments.

[sirsnyder]

Can you adjust AppVeyor to support IPV6?

[dktapps]

Sure, I'll create a PR. Also, some of these tests aren't working correctly (see https://travis-ci.org/krakjoe/pthreads/jobs/334677874#L800)

[sirsnyder]

Looks like a travis issue travis-ci/travis-ci#8711

[sirsnyder]

For the time being fixed with eaa0a58