This repository has been archived by the owner on Dec 16, 2019. It is now read-only.
Allow Volatile::extend() to work as expected #874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threaded
objects are often poorly suited for runtime class extension because of their immutability characteristics. Classes which are notThreaded
need to be adapted to extendThreaded
(for example, overwriting a coerced array on a runtime-extended class crashes).Because
Volatile
descends fromThreaded
,Volatile::extend()
exists, but does not work as might be expected - it behaves exactly the same asThreaded::extend()
.This PR changes
Threaded::extend()
to apply the scope it was called from, instead of always applying theThreaded
parent.A possible alternative to this could be to simply move
extend()
toVolatile
completely, since as I said aboveThreaded
isn't suited to code that doesn't know it'sThreaded
anymore due to immutability.