-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to disable Entrez search result limit #18
Allow to disable Entrez search result limit #18
Conversation
Ok hold on while I sign my commits... |
According to the [documentation](https://www.ncbi.nlm.nih.gov/books/NBK25499/#_chapter4_ESearch_), the limit currently is 10'000.
1775a3e
to
3c2b396
Compare
Also, yes, I've noticed the error above is different to the one mentioned in #19, and will be looking into if this is a problem. |
I don't think the readthedocs fail has anything to do with this PR, right? |
Hi @jonasfreimuth thank you for this! Can you please merge with the main branch which now includes a fix for the docs (#20) so that we can see if they build properly? |
Will do, hang on. |
Ok it's merged. @krassowski you might have to manually allow the other checks to run again... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jonasfreimuth
Fixes the limit on
max_results
forEntrezAPI.search()
and adds an option to ignore all similar limits.Should pretty much close #16, at least for my purposes.
Note: Running
pytest
on commit 3c2b396 resulted in the following output once, but the error disappeared after I ran it again without changing anything, the programmersdreamnightmare.