Question: Should we be setting any ground guidelines for what a Data Driven implementation is? #430
Comments
|
Similarly is it worth calling out reference implementations like VanillaJS, WC, etc.. since including them has value and they shouldn't be held to the same standards. |
|
Yeah, this is a fair point. For example DOMc has html hard coded in index.html https://github.com/krausest/js-framework-benchmark/blob/master/frameworks/keyed/domc/index.html So it does not need to create the DOM which is major slow down in JS API. This makes comparison difficult. |
|
there are a lot of libs that are starting to get into questionable territory lately. even for ivi, where @localvoid has historically held the philosophy of a straightforward, obvious implementation without "tricks" has drifted into using custom delegation logic and utilizing fundamentally it's still "data driven" but certainly not without "tricks". |
|
I'm totally fine to move reactive view into JS for the sake of consistency. I just can't understand blaming with the words "hard coded" and "does not need to create the DOM". domc was initially designed to work like VueJS, that has ability to reactivate the view defined in html. And it's not shortpath. Talking about event handling in top's: Yes, I also feel strange about working with the DOM, especially after long discussion about how 'Selected Row' should not be implemented switching classNames on |
I think the benefits of having html on the page (or SSR) is in metrics that are not currently captured by this benchmark:
since html parsing is done progressively (streamed as it's received over the network) it will outperform anything you do in JS (which must be fully parsed, compiled and executed before any painting can happen). EDIT: the amount of html that's pre-rendered by domc is pretty tiny and the real-world effect may not be noticeable. but if you pre-render 1,000 dom elements, then the benefits become very obvious. |
|
Thanks, @leeoniya ,
stage0 performs same as inlined code. Therefore, I can't say that inlined html is always faster. Though I'm fine to move view into JS, I still see no signs that it provides any meaningful benefit over other solutions to be able to say that it's making comparison difficult. I'm not stating that SSR provides zero-benefit, but looks like those benefits are hard to argue. |
for a tiny dom, sure.
you should try it, especially on a throttled connection and cpu ;)
there's quite a lot more that can be done during stream-parsing of html. for instance, images and fonts can start to be loaded in parallel, etc. |
|
Yes, I just built 1k prerendered domc page(without JS) and stage0 that runs 1k run on load.
I got literally same results with "No throttling" settings. And that's because benchmark server doesn't perform gzipping, therefore placing any SSR solutions in bad position. Edit: Actually, I just figured out that Lighthouse stated throttling in Runtime settings, despite that 'No throttling' setting. That's why I have same results. Edit: I was able to run benchmark's
Making it still hardly noticeable from performance perspective. |
|
when i have some time, i'll try to set up a proper test on my linode/nginx server (http2) with domc/1k and 1k pre-rendered static html. then run both variants through https://www.webpagetest.org/ with these settings:
|
I just gave up convincing everyone to remove all this BS[1][2] from their implementations. I've tried :) |
|
I made the comment about the entry point in respect to domc 0.0.2 implementation since it didn't use template parsing to bind top level event handlers. The current implementation does not have that issue. I actually don't think the way domc currently works as a particular advantage. Maybe in terms of lines of code or memory, but it still has to parse over the template. The per item template gets rendered then removed to be cloned for each iteration. Depending on the implementation this can be more visible and expensive especially on large complex pages. There is a big difference between this and SSR which pre-renders. It's actually usually a challenge for libraries to do this sort of parsing to do SSR since they expect the child render context to be the template and once rendered the templating information is generally lost. That being said SSR has big benefits for first paint, and depending on the diff mechanism clientside hydration can be more performant than the type of parsing/reconstruction domc is doing. But this is exactly the sort of discussion I was looking for. I do feel that a number of people consider something like React the baseline here. Even React and Angular sort of share some commonality in that React based it's original viability off the fact that Angular's digest loop wasn't really any more efficient than redrawing everything (in VDOM) and diffing. They both were fundamentally large central loop driven and top down. Not sure if everyone is familiar with KnockoutJS but it was an early pioneer for data driven client side (c. 2010). It introduced the concept of ViewModel which differed from the controller based MVC of the time in that VM's are instances much like Components. It was the first "Just a Render" library with MV* in mind and didn't concern itself with Model/Store implementation or even how you sliced up your ViewModels (Components). It has custom directives, an extension system, and disposal hooks. It does the same real dom parsing domc does. It's core is event driven rather than scheduled. In many ways it was way ahead of its time, and solved a lot of the same issues that React "revolutionized" nearly 4 years later. Vue's early design, Riot.js and a number of other libraries were inspired by KO. Over time there wasn't much innovation in this approach and times moved on. But it is a perfectly valid approach to data driven implementation. I submit this as another baseline for expectation of data driven library. I honestly don't see what the whole concern is with event delegation. Here's a whole official documentation page from Knockout.js on event delegation. To take this further having had to hack this for React, most libraries that auto do event delegation are broken by the Shadow DOM. With Solid I actually did attempt an automatic syntax(precompiled) and directive mechanism for this before realizing not only was it more convoluted, but it was an unnatural fit. I looked at Inferno and a couple other libraries to only come to the conclusion it was an example where the solution was worse than the problem. |
|
I believe in real applications people dont host their event listeners outside the component either so why here? In my opinion that is a task for the library to handle and then keep the application implementation simple. Also in early days this benchmark had React version where was one table and then each row was a component. Now the component is no longer there in many benchmarks. I understand that all libraries here dont have components in them, but why do we keep components in React then? Somehow I feel like the improvements and optimizations should be done in libraries and not in the app layer. What about correctness vs the speed? We could implement basic swaps / test cases before the test starts just to see it works as expected, we could port those from React/Inferno/Ivi repo. Also what about errors? Previously Inferno did not have any fallback behavior If application encountered ja exception in the middle of render. All your future renders would be stuck and application jammed for that vNode tree. |
Bugs aren't recoverable errors, there shouldn't be any future renders. |
|
@localvoid See code: Also I started wondering how do these libraries handle vNode hoisting, this is also a cost that Inferno and all inferno like libraries should do. Imagine you hoist a vNode and add it to multiple places in your application, in InfernoJS we need to clone the vNode or application might fail to runtime error. This is also done for all vNodes. Lately it was optimized to use bit for detection but because JS its still semi expensive. https://github.com/infernojs/inferno/blob/master/packages/inferno/src/DOM/patching.ts#L472-L474 |
|
@Havunen If you catch unhandled exceptions(bugs) and try to automatically recover from it, it means that you've traded correctness/security/etc for DX. It is a visual basic all over again. |
|
No, it does not catch any errors it marks vNodes which have been succesfully patched, so next render will correctly continue. If your library compares lastVNode to nextVNode and nextVNode becomes lastVNode at the end of render, then if your app crashes mid way of diff process. lastVNode will not be correct anymore and results into strange behavior. Unless there is internal vNode tree similar to React fibers this needs to be done. I think react does this too to internal VNode tree |
Then there is a possibility that some external state(application state) is corrupted and since everything lives in a shared memory, it is impossible to safely recover. Just because you've restored state for a virtual dom tree after you've encountered a bug doesn't mean that it will continue to work correctly. The only correct way is to crash an application. |
|
Yes, however user experience for end user would suffer |
|
I can create JSFiddle later to demonstrate it better. |
|
Agree, but with "auto-recovery" it maybe even worse (security issues, unexpected behavior). It is a trade-off, not something that everyone should implement. |
|
Well I would not call it recovery, it just keeps vNode tree in sync with real DOM tree. Another questionable area is Component root node swapping and vNode tree hoisting, many libraries copied patch / mount logic from InfernoJS but did not include logic of cloning vNodes with them, sure it looks like "wtf is this" because its everywhere, but isn't it expected behavior for a library to handle? |
Not so sure how other libraries are handling root node swapping, I think that almost all vdom libraries are handling this use case. vNode tree hoisting maybe not so important as it seems, Vue is doing fine without it, just another quirk that developers should be aware, like understanding the behavior of a children reconciliation algo. |
|
most libraries have specific useful features that add overhead, cannot be dead-code-eliminated, and do nothing useful in this benchmark. it's impossible to argue for unused feature parity in the context of perf. there's good reason why the impl requirements are rather loose. there's no need to enforce that each row is a component, because it adds overhead in some libs without any concrete benefit here. in react, the only way to short-circuit vdom regeneration is via shouldComponentUpdate, so row-components are a necessary optimization in that case, not simply a structural choice. i've mentioned this before, but imo library-supported optimizations/constructs is where the line should be drawn. it's easy to see when the ergonomics of each impl take a steep nose-dive into departure from initial uniformity and devolve into userland hacks like reading the row id back from textContent, wonders like i could make domvm's impl a few % faster by making similar impl clarity concessions. however, i've been simplifying the impl over time rather than optimizing it for this bench. i dont have too many issues with libs that are upfront about using the dom directly from start to finish. but seeing JSX (or hyperscript) for initial creation and then reading back or manipulating raw dom for perf reasons is a major smell to me. |
|
I don't really differentiate from JSX or String Templates or DOM templates (or maybe even some flavour of Hyperscript) at this point. It all is just a way to declare structure and bindings. Any choice made can be made in any. Like do you use js-dsl or some sort of fixtures to handle loops and conditionals? It's most customary to see these "fixtures" this in String or DOM templates but something I've seriously considered for JSX since using JS requires mapping then reconciliation which is extra work. Template Literal based libraries generally have the same js as DSL as JSX. At this point it feels a bit more of looks like HTML, effectively is HTML. @Havunen Event delegation doesn't necessarily mean outside of the component responsible for the state. That's actually one of the reasons I liked the most recent mechanism I did for Solid. It lets any event binding be the delegated handler. The idea that the row has to be a Component is where I have the most issue. It's actually one of my biggest awkwardnesses with React like libraries. When dealing with a List generally the parent has the most input on what the behavior should be when items are added/removed/selected. The row should reflect this state but all ownership is from the parent. In some cases yes most of the row/item is a child component other cases it's unnecessary, but I feel it's a very important choice for the developer to avoid unnecessary boilerplate, or rather to ease into the structure that fits as their application scales. I use a Web Components with Knockout at my day job in media heavy application and we use event delegation a lot in photo/video grids, feeds, etc. Mostly it is used at a Component level (our Webcomponent Base Class has an this.on method built in that listens for events from the component's Shadow Root) My experience with auto delegation at the library level has been fighting against it as creator of generic Web Component wrapper library. There is a great little library someone made for react to retarget events to be Shadow DOM compatible for React, and so there is a way to make these sort of libraries work. I think it's a perfectly valid choice for a Framework to make, it's just not the only choice. ====================== @leeoniya I think getting past event delegation, 'select' does have the greatest "smell" to it. It's been an area that I've been struggling with the most. From my experience with Knockout new Developers hit issues with understanding how to properly handle select(hover)/multi-select. It's because for fine grained you have essentially 2 different ways to solve the issue:
Knockout docs would lead you to believe approach 2 is the approach, but it is very verbose. 1 isnt inline with how they are thinking about the problem. One of the things I wanted to do with Solid is make this sort of operation "a thing", a binding delegation. The idea that if the source of change is local state outside of the data model (ie selection isn't persisted), that the handler could also be removed from the main render iteration much like an event handler is. Unfortunately lack of imagination or JSX syntax limitations sort left attempts to use standard binding syntax to represent this more confusing than useful. After seeing the Surplus implementation I felt it was much more inline to view this as a data transformation operator acting on the DOM directly. In so no need to introduce a new thing and just use a standard operator pattern for Solid. Does it look a bit fishy? Probably, although I designed it in a re-usable way to solve what I consider a real issue for these sort of libraries. It is packaged as part of the library. ========================= The suggestions I made in the original post were mostly what I saw could be framework agnostic constraints. I do get the sense that among the VDOM crowd because of expectation of VDOM implementations you guys judge other more specific things to be baseline atleast for those frameworks, since compromising those goes against the desired abstraction. I get it, Solid built using S.js (the same as Surplus) and I am very absolute in making the implementation use ES Proxies for simple object access instead directly using S Signals which would considerably improve the performance in a number of benchmarks. In someways Solid will never be more performant than Surplus so I'm constantly trying to find other ways to improve performance or make the developer experience better (in my eyes). I guess the challenge here is are there any constraints that makes sense as much for React as they do for say DomC. I'd venture to say that Stage0 is arguably a reference implementation and that it breaks some of the rules, but I don't believe I've captured that in the initial post. Nothing against Stage0 but it doesn't share several of the same characteristics that even DomC does. It has no declarative binding system and requires hand written update methods. But maybe I'm wrong since sometimes when I read some VDOM implementations, where there are chained specialized functions adding inlined event handlers and the like, while it's a different DSL and I know it's using the VDOM it looks just as sequential control flow oriented(dare I say imperative) as the underlying DOM manipulations that Stage0 is doing. And that's the thing because VDOM is scheduled and redraws downward despite the tools like JSX we use to make it look different. Is the running of say IVI or React any less imperative than Stage0. Is that even a thing? How much squinting does it take for React.createElement to look like document.createElement? I asked the question because I actually don't know. Maybe because we shouldn't restrict on features that aren't necessary for the Benchmark this whole thing is a wash. I was looking to see if there was a concrete definition for data driven. Like if data binding could be defined. If there was something that makes these libraries/frameworks recognizably different from jQuery (or perhaps something like Stage0). I think if there is a way the conversation starts at what we consider the minimum, and then see if we can raise the bar over time. |
If you are trying to solve a "performance" problem with auto event delegation, then it is definitely not worth it. React and ivi are doing it to get more control over event order, event flow and scheduling, there are use cases like RTE that require doing this stuff to solve issues with different browsers. Also, when I've designed synthetic events in ivi, I've tried to make them flexible enough, so I can try to experiment with an efficient generic solution for Gestures/DnD. By using explicit event delegation in the benchmark implementation, you just forcing everyone else to rewrite their implementations(every single one can be implemented this way), because obviously it can reduce alot of memory allocations. Synthetic events in ivi require additional 72+(closure size) bytes per each event handler, so to those who compete at this low numbers it can make a noticeable difference. If I remove explicit event delegation from the ivi implementation, it will consume more memory than Inferno implementation and I am ok with it. |
|
@localvoid I meant from a Shadow Root perspective. Like I've written different auto event delegation patterns, versions of Solid have been submitted here with them until I removed them. I didn't feel the complication was worth it. I was trying to look at the DOM structure to decide where to put the handler mount points, or make a system that involved multiple bindings. I needed to change how the events worked in order to make it fit for everything so it introduced awkward caveats for events not fired from the framework. Basically the complexity almost completely negated any benefit and I don't just mean performance, I mean cognitively. Like do you stick the handler on the body? Does it consider composed and non-composed events over Shadow Roots? I know there are some solutions in this zone, but events are a universal DOM concept that go beyond any frameworks ability to use/wrap them. Do you guys know if your framework's event delegation works if your mount point is in a Shadow Root or if you are dealing with multiple nested Shadow Roots? =======================================
The only reason I'm differentiating 3 from 4 is that I think there is a big difference between getting passed an object from an event and reading it, and say being expected to mutate it or know how to traverse over the tree. And the difference between 2 and 3a is the former is the main update loop, and the latter is essentially an event handler/directive. But again this separation is probably largely due to how I perceive severity of issues. Like I don't really consider 4 a thing. If a library can write: const div = <div />Then you are aware of a DOM node. Similarly event.target is a thing. Level 3 is a bit more egregious in that you are telling people to mutate or traverse the structure. It's easy to see how depending on the implementation some view refactoring could break the functionality here. Still it's a reasonable place for optimization in your actual projects and a library exposing this as an option isn't terrible but it crosses a line. Everything above that is generally where I draw my line here. But I've definitely broken all the rules in real applications. I know I could make my Solid implementation be completely compliant, but I don't feel that is the most representative of how you'd use the library. I think Level 3 compliant is possible too without compromising really but it's a small technicality (a small API abstraction) that wouldn't stop this general use pattern in the future elsewhere in the library. |
|
Really interesting conversation. I wish I could take part more, but my startup has been getting some traction over the last few months and I'm totally slammed. Whatever comes out of this discussion, can I ask as a courtesy between us framework authors that we not disparage and spread falsehoods about each others' work on other forums? And if you do, would you at least identify that you have a horse in the race on which you're commenting? (Funniest part of the above exchange is when @naasking asks @localvoid "As an aside, do you have any experience with Ivi?") We can respectfully disagree about approaches without anonymously spreading FUD about each others' work. My position with Surplus, as I've said before, is that I think it's a flaw for modern frameworks to redefine as core a part of DOM semantics as event propagation. That's not the final word on it -- it's a design decision, meaning it has tradeoffs, and those may play differently in different scenarios. For instance, in the past, when there was so much difference between browsers' event behavior, a normalized synthetic event system made sense. For VDOM authors, the encapsulation provided by VDOM makes it hard to add event delegation outside of the core library. Surplus doesn't have that issue. Since it exposes real nodes, an event delegation system can easily be added as a library. I haven't, because a) I haven't found an abstraction I liked well enough, and b) I haven't felt a need great enough. @localvoid I have nothing but resepect for your work with with ivi. I think it's a great library. We're pursuing different approaches, which is a good thing for the ecosystem as a whole. If I ever do write an event library, I'll certainly take a look at what you've done. I hope there's some use to you in Surplus as well. As for domc, I think the approach of real dom nodes with code gen and top-down data binding is a promising one and I'm glad @Freak613 is exploring it. It's the only approach here that makes me think I might not be able to beat it with Surplus :). That said, the implementation was clearly at a very early stage when I looked at it (the initial submission). Basic things caused it to blow up:
I hope those were symptoms of an early stage of development, but I was a little concerned that some of them looked like they might have been intentional tradeoffs to make the compiler small and fast (e.g. processing code using Best |
I think that you should remove this from surplus documentation: "There are no components, no virtual elements, no lifecycle, no setState(), no componentWillReceiveProps(), no diff/patch, etc etc.". This is the main reason why I thought that surplus doesn't have lifecycles, components and diff/patch algorithms. S nodes are "components", S nodes have lifecycles, S nodes have diff/patch algorithms. It is the same dataflow pipelines, in React you are just always pushing all input data top-down and in surplus you are observing data changes/diffing/pushing further.
Here is an example https://github.com/NekR/preact-delegate , with some modifications it is possible to make it efficient and just attach some data(model) instead of event handlers.
I just don't understand why you need to abuse every possible "hack"/advantage in the benchmark implementation, the same thing were historically with Inferno when I've asked many times to remove recycling from the benchmark implementation. I just don't get it.
I strongly believe that for some use cases it is a superior approach. |
|
Here is how I could create a simple "idiomatic" API for event delegation in React-like library that doesn't touch DOM nodes directly in userspace: const ACTION = Symbol();
const ROW = Symbol();
function RowList({ rows }) {
return (
<ul
onClick={delegatedEventHandler([ACTION, ROW], (ev, data) => {
if (data[ACTION] === "remove") {
remove(data[ROW]);
}
})}
>
{rows.map((row) => <Row row={row} key={row.id} />)}
</ul>
);
}
function Row({ row }) {
// Here is one of the reasons why I don't like JSX :)
// return <li [ACTION]="remove" [ROW]={row} />;
return React.createElement("li", { [ACTION]: "remove", [ROW]: row });
}
// And this is just an implementation detail hidden from userspace in some external library.
function delegatedEventHandler(symbols, handler) {
return (ev) => {
const data = {};
let node = ev.target;
while (node !== ev.currentTarget) {
for (let i = 0; i < symbols.length; i++) {
const k = symbols[i];
const d = node[k];
if (d !== void 0) {
data[k] = d;
}
}
}
handler(ev, data);
};
} |
|
@ryansolid There is also mixed libraries like preact which diffs vDOM to real dom. |
|
@Havunen So perhaps it isn't so clean cut? My thinking is that once you you have resigned yourself to rendering a Virtual DOM a certain level of abstraction is necessary and it's something that defines all these frameworks. I realize this is somewhat arbitrary labeling. But the idea is that the list is fixed and defined as well as can be and the implementations self identify. This discussion has in one way or another been going on for over a year. I wasn't trying to get back into "Oh look how Surplus Impl knows that events have DOM elements, and that those elements have a className property. For Shame!!" But I recognize I was essentially doing the same thing with the first DomC submission (it's been addressed since) and Stage0 which invited this conversation back in. So while I strongly feel the complete list (other than the non-keyed separation) is what we should generally be looking at and that it doesn't make sense to exclude any data driven implementation (maybe that even means you jQuery, if you can get up from your walker), I think there is a potential here to define more zones that authors and viewers a like vie for their frameworks to dominate. It takes a bit of pressure off trying to hold to a single standard which I don't think we're getting any closer to reaching and for any framework except those really vying for the top spot, it can disincentivize weird hacks as it gives them a place where they can be judged more on commonality. Stefan has provided great tools to do this already but it takes knowing what you are looking for. |
I don't understand what is the difference between LitHTML/Angular and React. LitHTML creates a static template + set of instructions that diffs input data and applies data changes, Angular generates diff instructions directly as JS code(incremental DOM) and diffs logical DOM(virtual DOM) using this set of instructions, React does the same and the only difference is that instructions are basic JS values like in the lisp(code as data). In fact, I don't see too much difference in a level of abstraction between this libraries and Surplus, the only difference is that Surplus requires observable values everywhere and other libraries can use different strategies to manage state. |
|
Thats fair, I guess I was trying to tie too many commonalities with my experiences where there are none. Surplus in it's fine grain execution can toss around an JSX tag as if it sees fit as if it was a DOM node but that isn't anything common. Knockout was very strict about exposing the DOM outside of directives (with one exception being event delegation). It was working with webcomponents that really blurred the lines for me. When the container ends up being a DOM element itself there is this weird duality. But you are right it isn't a concern of the renderer. Just because say LitHTML is often used in Webcomponents doesn't necessarily make the abstraction different. Different solutions have abstracted the internals of Custom Elements differently which probably is more of a consideration than how the view is presented or changes are propagated. So perhaps the original post covers it. And it's just a matter of identifying Reference builds. But so I understand, the primary issue here with Surplus like code is that it exposes the details to the implementation. If a library did all the same things but wrapped it's premade constructs say a directive that ships with the library that would be fine. Like that React-like Event Delegation example. If the implementation author didn't think it was worth making it part of the library ecosystem it doesn't belong here. Event Delegation being so widespread more controversial, but that covers hacks like rAF and the like. |
|
Also more related to the original post although I'm not sure how to enforce it (if it's a matter of having a certain tests), should there be a baseline set of features. We agree that every library/approach is different so we won't have feature parity, but at the baseline. I wrote:
I feel like if a library isn't fully functional here it is misrepresenting itself. While I'm sure it won't be hard for @Freak613 to add, DomC doesn't have conditional directives. This might not be obvious from VDOM perspective where an if statement suffices, but for a pure string templated system it has be in a directive. The benchmark doesn't need it, but from a usage standpoint the library would be glaringly incomplete. However, for users coming to view the results it isn't really apparent until they dig in. This isn't to point fingers more to wonder if there is a statement that can be made before people even submit their libraries/frameworks so they have an idea of expectations. |
|
Fine Grained Reactive are going to continue be an issue for uniformity. Realistically you can write anything in a computation and it works. @luwes The Sinuous implementation is worth bringing up here. Technically it isn't breaking the stipulation I made in the first post here and can recreate the view from any rest state. But it takes the Surplus/Solid approach even further not even pulling a ref from the rendered nodes. Instead just straight up doing a document.querySelector right in the middle of the computation. I'm not one to call the kettle black and while the hook Solid uses is completely abstractable, I just figured this should be on the radar. |
|
@ryansolid good you brought this up, I wasn't aware at the time it was not allowed but I've been making some optimizations and coincidently changed this along. PR #575 |
|
I'm not sure it is or isn't. Technically from what I was proposing it's fine I think. I just wanted to draw attention to it more just to point out how slippery the slope is even in my definition. When html |
Instead of forcing everyone to read through your library code, is there something special about this implementation that makes it a good reference in particular? I'm sure a vast majority of libraries here are good examples. Like no one would say the React implementation is contentious. The problem isn't the challenge finding an ideal example. It doesn't exist, every library is different and they are all beautiful in their own way. It is trying to define what the lowest common denominator is, if that is even possible. |
|
It's impossible to totally tell if an implementation is data driven by just looking at the implementation code. Especially when you consider things like proxies which can be hiding almost anything behind it. I suppose you could tell which is definitely not, but even in the Mikado Swap case I had to look at the library. Swap could be a generic data function. You most definitely need to look at the library code to be sure to understand what is going. Which is perfectly fine and expected. So I was just asking in the sake of saving time and effort. Truthfully I don't see anything particularly special on the surface of the implementation. I see some syntax choices but this implementation looks similar to most. MobX uses proxies a similar way at least on the surface. Vue uses getter/setter objects which can work sort of similar. Sorry if I seem dense, I'm asking because I honestly am not seeing what the difference is. Most implementations involve similar methods that set state values. Many use functions, a couple use Proxies but it is effectively the same since Proxies are just function calls. Now something your library is doing could be different but I wouldn't know that without going through the library source code of this proxy feature. Although a better question I suppose is the point being made. Are you saying other implementations are not data driven? I would say most are and there are a few questionable decisions made by some libraries. Do you have a different take? |
|
Yes that mobx jsx example is good example of something contentious. Half of this thread is about Surplus using that approach as an example. If you look at the rest of that implementation or look at React MobX that isn't the case. It is proxy triggered update. Vue doesn't call a render or setState function. It triggers on data set via the setter. That being said admittedly I'm a bit surprised about the need to clone as documented but it is the same sort of mechanism. It is possible all the Vue 3 (which still hasn't come out) demos affected my view of it. There are probably more in here. NX which was removed because it hasn't been updated in 2 years also used this approach. Knockout ES5 is a library that has been doing similar since 2014. Basically it isn't a particular new approach. Solid worked that way 2016 time period (before I open sourced it). Even at that time I didn't necessarily consider new or unique. Sorry I've kind of gone off the rails a bit. I can clearly see how you would have not come across this before naturally and have developed something cool for yourself. It was just the rhetoric that has accompanied this that has me still discussing this. But this is sort of beside the fact. I don't think you need this to be a particular good example of being data-driven. Pointing out the select row approach as being nefarious fair. By the way that isn't the only way people are getting around it. Others are adding an So I guess we do see different things. I tend to see the similarities in things since it makes it easier to classify and follow larger trends. |
|
Yeah it comes with having customers and being out there for years. MobX itself is was really influenced by KnockoutJS and the other Reactive libraries in the early 2010's. Vue also has this influence too. Surplus/Solid/Surplus etc all owe their heritage to Knockout. Luckily us as newer libraries don't need to carry that legacy. This area is my passion for frontend development. I've been very keenly aware of trends and approaches here so understanding that Solid for instance was trying to take those libraries by give them the interface of VDOM libraries. There are a lot of tradeoffs. It was through this walking the line back and forth I've developed my perspective of all things be more or less similar, because I travel back and forth between these libraries to pick and choose the parts I like.. makes me very opinionated. But on the other side it is why I am not too quick to point at an idealized form. It is really all sort of the same. Which back to the thread topic, I wonder is there some common baseline we can agree on for these benchmarks. I mean anyone can do whatever they want, but how do we possibly compare on similar axis yet let each library can highlight its strengths and tradeoffs. |
|
With Surplus removal, #772, and #794 we remove the legacy around certain categories of hacks. I know it is still out there in a couple of places but I'm hoping to remove the precedence. For selection, that just leaves the putting the selected state on each row, as a way of sidestepping the test. I was trying to think if I had a simple heuristic for deciding if an implementation goes against the spirit of the benchmark and I came up with one.
Swap changes index in the array. Create sets top-level data as does selection. Only update every 10th row involves direct nested data manipulation. Regardless of if you expose the DOM or not if the user implementation code assigns any other nested value during due to one of the click actions you are probably side-stepping the benchmark in some way. |
|
I'm closing older issues that won't get fixed. |
I know this sort of thing has come up before (#230). But that's not my intention. When I first submitted Solid I did several things unknowingly mimicking the vanillajs implementation not realizing it was generally seen as bad form. They might not be the type of considerations a VDOM library would consider, but in the range of data-driven libraries perhaps there is something here that should be said.
Roughly I'm thinking:
A data driven library should provide at minimum:
An implementation should:
Is calling this out unreasonable? Is this too restrictive or specific?
The text was updated successfully, but these errors were encountered: