Updates to solid, ko-jsx, mobx-jsx #490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty major change to the API of the underlying renderer where it is no longer automatically wrapping every expression. This prompts a new release for all 3 of solid, ko-jsx, mobx-jsx. Some decent memory improvements for the first 2 but mobx-jsx doesn't seem to have really benefited from this update.
Also an even more significant update to solid to reduce API surface, and code, and increase compatibility with libraries like S.js and Surplus, at what I figure should be a noticeable performance change (it now wraps with ES6 proxies in all cases along the whole state tree which should have an overhead). As to the suggestions out of the setting a baseline discussion(#430) I'm attempting something similar to @localvoid event delegation example API. I'm still sort of out on it, as it seems like it's good from an event bubbling perspective so the implementor doesn't need to trace a DOM tree, but I mean reading DOM events is so primary (like event.target.value to read from an input) that I'm not sure it makes sense to be a thing.
I've spent the past week using this benchmark to try to reduce memory and regain that perfomance so hopeful net isn't so bad. This is one of those roll the dice commits in terms of performance, but I believe it's a big step forward for these libraries. I look forward to seeing the results.