Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to solid, ko-jsx, mobx-jsx #490

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

ryansolid
Copy link
Contributor

@ryansolid ryansolid commented Nov 17, 2018

Pretty major change to the API of the underlying renderer where it is no longer automatically wrapping every expression. This prompts a new release for all 3 of solid, ko-jsx, mobx-jsx. Some decent memory improvements for the first 2 but mobx-jsx doesn't seem to have really benefited from this update.

Also an even more significant update to solid to reduce API surface, and code, and increase compatibility with libraries like S.js and Surplus, at what I figure should be a noticeable performance change (it now wraps with ES6 proxies in all cases along the whole state tree which should have an overhead). As to the suggestions out of the setting a baseline discussion(#430) I'm attempting something similar to @localvoid event delegation example API. I'm still sort of out on it, as it seems like it's good from an event bubbling perspective so the implementor doesn't need to trace a DOM tree, but I mean reading DOM events is so primary (like event.target.value to read from an input) that I'm not sure it makes sense to be a thing.

I've spent the past week using this benchmark to try to reduce memory and regain that perfomance so hopeful net isn't so bad. This is one of those roll the dice commits in terms of performance, but I believe it's a big step forward for these libraries. I look forward to seeing the results.

@krausest
Copy link
Owner

krausest commented Dec 2, 2018

FYI: I'm a bit busy at the moment. I hope to merge it later this week.

@krausest krausest merged commit bf37c3c into krausest:master Dec 4, 2018
@krausest
Copy link
Owner

krausest commented Dec 5, 2018

Thanks - here are the results:
bildschirmfoto 2018-12-05 um 20 19 45

@ryansolid ryansolid deleted the jsx-dom-expressions branch December 26, 2018 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants