Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New uhtml library benchmark #698

Merged
merged 2 commits into from
Mar 3, 2020
Merged

New uhtml library benchmark #698

merged 2 commits into from
Mar 3, 2020

Conversation

WebReflection
Copy link
Contributor

@WebReflection WebReflection commented Feb 23, 2020

µhtml is a simplification of lighterhtml so that it weights ~2.8K instead of ~5.5K.

Current PR adds both keyed and non-keyed results to the mix.

Thank you in advance for considering this new "micro" entry 👋

uhtml-lighterhtml

@WebReflection
Copy link
Contributor Author

as nothing happened so far, I'd like to put this PR on hold, as I'm bringing keyed results in too, through my latest commit, that needs some refinement, but it's 99% ready to go.

@WebReflection WebReflection changed the title New uhtml library benchmark (non-keyed) New uhtml library benchmark Feb 27, 2020
@WebReflection
Copy link
Contributor Author

WebReflection commented Feb 27, 2020

@krausest FYI the merge request has been updated with both keyed and non keyed benchmarks, this could now be merged.

@krausest
Copy link
Owner

Thanks. I‘m on holidays this week so I‘ll merge when I‘m back.

@krausest krausest added the merging started merging started (no more updates please) label Mar 2, 2020
@krausest
Copy link
Owner

krausest commented Mar 3, 2020

@WebReflection I started merging before your last commit. Results are updated.
I'll merge the last commit the next few days.

@WebReflection
Copy link
Contributor Author

@krausest my apologies, I should've checked the label before pushing. I don't think there's much difference with latest, I was just updating udomdiff with comments and a tiny fix that was worth pushing an update for.

I'll try to resolve conflicts now, hopefully that helps too.

@WebReflection
Copy link
Contributor Author

actually the version conflicting was 1.4.4 but the table shows 1.4.6 ... anyway, conflicts gone 👋

@WebReflection
Copy link
Contributor Author

@krausest I've published again but my latest commits are mostly related to changes in the README, so I don't think you need to re-run anything in there.

However, I've realized why the version is 1.4.6, because I haven't pinned uhtml to the exact version, I have simply used the default npm semver, which allows patches behind the scene.

At this point I have two questions:

  • should libraries land only with exact pinned version in the package.json, or it's OK to use the default npm semver rule?
  • do you want me to pin to the exact latest version, or it's OK as it is now?

I guess you could also save your time by skipping a re-benchmark, as I know it takes some time 👋

@krausest krausest merged commit e18091c into krausest:master Mar 3, 2020
@krausest
Copy link
Owner

krausest commented Mar 3, 2020

No problem - I pinned the versions and merged the PR (and re-run the benchmark). From my experience anything but fixed versions lead to broken builds (though I wouldn't transfer this advice to real world projects).

@krausest krausest removed the merging started merging started (no more updates please) label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants