Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/firestore/override database #209

Closed

Conversation

mcadet
Copy link

@mcadet mcadet commented Jan 12, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #205
or
Closes # (issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@mcadet mcadet closed this Jan 12, 2024
@mcadet mcadet deleted the feat/firestore/override-database branch January 12, 2024 10:36
@jeromegamez
Copy link
Member

@mcadet I'm not sure if it was on purpose, but could you reopen the MR? Then I would merge it 😅. Otherwise I'll copy your changes and push them myself, making sure that the commit(s) are attributed to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to override FirestoreClient::DEFAULT_DATABASE
3 participants