Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a warning of Link component - React 15.3.0 #788

Closed
fchienvuhoang opened this issue Aug 2, 2016 · 3 comments
Closed

a warning of Link component - React 15.3.0 #788

fchienvuhoang opened this issue Aug 2, 2016 · 3 comments
Assignees
@langpavel
Labels
branch feature/react-intl branch feature/redux bug

Comments

@fchienvuhoang
Copy link

fchienvuhoang commented Aug 2, 2016 •
edited
Loading

Hi all,
Just a warning when used Link component with react 15.3.0

screen shot 2016-08-03 at 6 27 20 am
@langpavel
Copy link
Collaborator

Ahh, It's probably related to feature branch, isn't it?

@langpavel langpavel self-assigned this Aug 4, 2016
@langpavel
Copy link
Collaborator

TODO: Remove navigate from props at https://github.com/kriasoft/react-starter-kit/blob/feature/redux/src/components/Link/Link.js#L66

langpavel added a commit to langpavel/react-starter-kit that referenced this issue Aug 4, 2016
@langpavel
Exclude navigate from <a> in Link component [closes kriasoft#788]
c11b060
langpavel added a commit to langpavel/react-starter-kit that referenced this issue Aug 4, 2016
@langpavel
Exclude navigate from <a> in Link component [closes kriasoft#788]
b16bc90
langpavel added a commit that referenced this issue Aug 4, 2016
@langpavel
Merge pull request #791 from langpavel/fix-788
9195ea1 
[feature/redux] Exclude `navigate` from <a> in Link component [closes #788]
@fchienvuhoang
Copy link
Author

yes, on redux branch. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@langpavel langpavel

Labels
branch feature/react-intl branch feature/redux bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@langpavel @koistya @fchienvuhoang