Change db string length #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zzh8829 looks good, thanks! |
|
Do we need explicitly STRING(255)? Default size for STRING in sequelize is 255 chars. Length can be omitted in this case, in my opinion. |
koistya
pushed a commit
that referenced
this pull request
Jul 10, 2016
* Update npm modules; tweak Stylelint settings * Change db string length (#691) * Update history module to v3 (#692) - Update `history` dependency to v3.0.0 ([changelog](https://github.com/ReactJSTraining/history/blob/master/CHANGES.md)) - Add `windowScrollX` and `windowScrollY` helpers to `core/DOMUtils` - Rename `match()` to `UniversalRouter.resolve()` - Fix scroll issues ([see article](https://developers.google.com/web/updates/2015/09/history-api-scroll-restoration)) * fix(Isomorphic Style Loader): Add support to load multiple styles (#678) * fix(Isomorphic Style Loader): Add support to load multiple styles * fix(Isomorphic Style Loader): Add remove feature back * Adds testing section (#687) Integrates comments by @langpavel * Fix npm warnings about graphql dependencies (#693) fixes #661 * Fix OccurrenceOrderPlugin spelling (#683) * fixed typo in passport.js (#696) * Docs: use more expressive language (#701) * Update stylelint-config-standard (#707) * Update stylelint-config-standard When I run 'npm run lint', this warning show up: Deprecation Warning: 'number-zero-length-no-unit' has been deprecated, and will be removed in '7.0'. Use 'length-zero-no-unit' instead. See: http://stylelint.io/user-guide/rules/length-zero-no-unit/ update package to remove it. * Update stylelint to use length-zero-no-unit instead number-zero-length-no-unit. * Fix spelling of "vice versa" (#710) * Remove jade dependency * Update react-style-guide.md (#718) replace ../Nav with ../Navigation * Update CHANGELOG.md
koistya
pushed a commit
that referenced
this pull request
Jul 10, 2016
* Add support for helpers in redux-thunk actions (#650) Support for isomorphic `fetch` and `graphqlRequest` helpers in redux-thunk action creators * [feature/redux] Fix: Redux helpers client configuration (#663) * Update npm modules; tweak Stylelint settings * Change db string length (#691) * Update history module to v3 (#692) - Update `history` dependency to v3.0.0 ([changelog](https://github.com/ReactJSTraining/history/blob/master/CHANGES.md)) - Add `windowScrollX` and `windowScrollY` helpers to `core/DOMUtils` - Rename `match()` to `UniversalRouter.resolve()` - Fix scroll issues ([see article](https://developers.google.com/web/updates/2015/09/history-api-scroll-restoration)) * fix(Isomorphic Style Loader): Add support to load multiple styles (#678) * fix(Isomorphic Style Loader): Add support to load multiple styles * fix(Isomorphic Style Loader): Add remove feature back * Adds testing section (#687) Integrates comments by @langpavel * Fix npm warnings about graphql dependencies (#693) fixes #661 * Fix OccurrenceOrderPlugin spelling (#683) * fixed typo in passport.js (#696) * Docs: use more expressive language (#701) * Add eslint global-require exception (#703) Add eslint global-require exception, based in 'src/server.js' file. The 'feature/react-intl' branch also has this problem. * Update stylelint-config-standard (#707) * Update stylelint-config-standard When I run 'npm run lint', this warning show up: Deprecation Warning: 'number-zero-length-no-unit' has been deprecated, and will be removed in '7.0'. Use 'length-zero-no-unit' instead. See: http://stylelint.io/user-guide/rules/length-zero-no-unit/ update package to remove it. * Update stylelint to use length-zero-no-unit instead number-zero-length-no-unit. * Fix spelling of "vice versa" (#710) * Remove jade dependency * Update react-style-guide.md (#718) replace ../Nav with ../Navigation * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using mysql with the current configuration will cause
ERROR 1071 (42000): Specified key was too long; max key length is 767 bytesSee http://stackoverflow.com/a/16820166 for the change
I think we should make this project compatible with other databases such as mysql.