Enables to toggle server side rendering when running the server. #833
Conversation
…iguration has a new key named `serverSideRendering` that can be toggled between `true` and `false`. Related to: kriasoft#642, kriasoft#634
|
It may be better to just not use |
|
The issue with that is that you need extra work to setup, and managing an extra index.html page. Probably could be rendered once and then served. Then you would need another server config to serve this index.html page including all the static files + hot reload... |
|
SSR in RSK already configured and allows to do following:
So, I do not understand your benefits. |
|
@frenzzy i think this can be great pull request... since server side rendering as we all know produces some delay... (since ajax has to be performed and wait for rendering to happen after that)... if this pull request can be modified such to perform client side rendering in case of real user and ssr for google crawl bot then it would provide the user with a better user experience in terms of lower page load times (since the app does not need to perform ajax and rendering on server side)... and it would also be good for seo since ssr can be performed in case of google bot... I see many major companies taking this approach now a days such as flipkart... Great pull request... though the value of |
|
@frenzzy This is entirely for development reasons; Sometimes you get server side errors and the whole app doesn't start or behaves unexpectedly; If is just client side rendering, you can debug errors easily; At least that is what I've noticed. |
|
Another reason, that happened just now, is that sometimes there is an error and the server doesn't even start, in this case I will disable server side rendering and investigate the issue on the client side. |
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| export const port = process.env.PORT || 3000; | |||
| export const host = process.env.WEBSITE_HOSTNAME || `localhost:${port}`; | |||
| export const serverSideRendering = true; | |||
There was a problem hiding this comment.
Use export const disableServerSideRendering = !process.env.DISABLE_SERVER_SIDE_RENDERING;
| @@ -27,7 +27,7 @@ import models from './data/models'; | |||
| import schema from './data/schema'; | |||
| import routes from './routes'; | |||
| import assets from './assets'; // eslint-disable-line import/no-unresolved | |||
| import { port, auth } from './config'; | |||
| import { port, auth, serverSideRendering } from './config'; | |||
There was a problem hiding this comment.
disableServerSideRendering
| @@ -84,31 +84,30 @@ app.use('/graphql', expressGraphQL(req => ({ | |||
| // ----------------------------------------------------------------------------- | |||
| app.get('*', async (req, res, next) => { | |||
There was a problem hiding this comment.
Disable SSR on router level, not inside handler, add default app loader
|
Thanks @langpavel but I'm not sure if is worth investing more time fixing the conflicts and adding your suggestions if it won't be accepted anyway. |
|
Anyway thanks |
Configuration has a new key named
serverSideRenderingthat can be toggled betweentrueandfalse. Related to: #642, #634