Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use location.reload() when client-side routing error occur #900

Merged
merged 1 commit into from
Oct 4, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
# (this is required in order to prevent newline related issues like,
# for example, after the build script is run)
.* text eol=lf
*.css text eol=lf
*.html text eol=lf
*.jade text eol=lf
*.js text eol=lf
*.json text eol=lf
*.css text eol=lf
*.less text eol=lf
*.scss text eol=lf
*.sss text eol=lf
*.js text eol=lf
*.json text eol=lf
*.md text eol=lf
*.sh text eol=lf
*.txt text eol=lf
Expand Down
2 changes: 1 addition & 1 deletion docs/recipes/how-to-use-sass.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ $ npm install sass-loader --save-dev

### Step 2

Update [`webpack.config.js`](../../webpack.config.js) file to use `sass-loader` for `.scss` files:
Update [`webpack.config.js`](../../tools/webpack.config.js) file to use `sass-loader` for `.scss` files:

```js
const config = {
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@
true,
{
"ignorePseudoClasses": [
"global",
"local"
"global"
]
}
]
Expand Down
2 changes: 1 addition & 1 deletion src/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ async function onLocationChange(location) {

// Avoid broken navigation in production mode by a full page reload on error
console.error(err); // eslint-disable-line no-console
window.location.href = createPath(location);
window.location.reload();
}
}

Expand Down