Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a gene name to input gene conversion table #316

Closed
ChristopherMancuso opened this issue Sep 5, 2024 · 3 comments
Closed

a gene name to input gene conversion table #316

ChristopherMancuso opened this issue Sep 5, 2024 · 3 comments

Comments

@ChristopherMancuso
Copy link
Contributor

ChristopherMancuso commented Sep 5, 2024

need to check these files exist in the backend data then should be easy to implement. may need to check if these extra files will make us need a larger function for this part

@vincerubinetti
Copy link

To clarify, the request here is to put include gene "names" in the input_genes field of the analysis results, e.g.:

{
  input_genes: [
    {
      input: "CASP3",
      entrez: "836",
      in_network: true,

      // add
      name: "Caspase 3"
    },

    // ... another gene
  ]
}

@ChristopherMancuso ChristopherMancuso changed the title a gene symbol to input gene conversion table a gene name to input gene conversion table Sep 5, 2024
@ChristopherMancuso
Copy link
Contributor Author

yeah the is what I'm getting from Arjun's request too, but probably the order would be Input, Name, Entrez. I'm iffy on this as Names can make the data frame much wider and look not so great as you know, but we can give it a try.

ChristopherMancuso added a commit that referenced this issue Sep 12, 2024
ChristopherMancuso added a commit that referenced this issue Sep 16, 2024
* fixed issue #315

* fixed issue #314

* fixed issue #237

* fixed issue #316

* fixed issue #321

* fixed issue #317

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@ChristopherMancuso
Copy link
Contributor Author

fixed with #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants