Improving request normalization #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good. I’ll land and cerry pick into v2. |
kriskowal
added a commit
that referenced
this pull request
May 29, 2014
Continued refinement of request normalization and fixed cookie handling.
kriskowal
added a commit
that referenced
this pull request
May 30, 2014
Continued refinement of request normalization and fixed cookie handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving all normalization logic to a single function and passing resulting request object directly to
http.requestwithout reassignment which caused some params loss (socketPath,auth).Should I do the same in the v2 branch?