Add ser_as_str feature to serialize using serialize_str() #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serializer may not support collect_str, as is the case with serde_json_core crate.
|
Merged and published on crates.io, thanks @elrafoon |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing a lot of no_std firmware development, and frequently use serde_json_core crate.
This serializer does not support collect_str() used in ipnet's serialization code since 1096c55.
This patch adds new feature to enable serialization by formatting Ipv*Net addr to heapless::String and then serializing using serialize_str(). Since maximum formatted address length is fixed, and not too big, memory usage is still very low.