Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Client.php #100

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update Client.php #100

wants to merge 4 commits into from

Conversation

TParis
Copy link

@TParis TParis commented Jun 29, 2021

Thanks for your pull request!

Before we consider merging it, please take the time to ensure you are complying
with these guidelines:

  • [ x] I have described my changes in the
    CHANGELOG
  • [ x] I have adopted the
    coding style
  • [ x] I have followed the contributor
    rules
  • [ x] I have added consistent PHPDoc documentation to
    symbols I added
  • [ x] I have fixed an issue and I added unit test
    case(s)
  • [x ] I have added a feature and I added functional test
    case(s)
  • [ x] I have passed all continuous integration checks or discussed with project
    maintainers of special treatments for exceptional cases
  • [ x] I accept my contribution to be code-reviewed by project maintainers and
    will refine it as requested
  • [x ] I accept my pull request to be rejected at the project maintainers'
    discretion, even if it complies with all the above guidelines

Failure to comply with the above guidelines will lead to your pull request
being either modified for compliance, ignored until modified for compliance,
and/or rejected altogether.

Copy link

@siapep siapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to make exactly the same PR.

It is useful for multi tenant applications on Azure.

@GenieTim
Copy link

I would appreciate these changes as well in order to restrict the tenant.
Would you mind merging them, @krizalys, please? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants