Feature/seller sales statistics #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add endpoints to fetch sales data for the last 30 days, the last year, and the last three years for sellers. - Implement user role validation to ensure that only sellers can access these services. - Sort returned sales data by period for better analytics insight. This commit enhances the SalesVolumeAPIController by providing comprehensive sales data analytics over various periods. It ensures that these analytics are securely accessible only to users with the seller role, thereby enhancing the application's security posture.
Added unit tests to verify the behavior of the SalesVolumeAPIController. These tests ensure the successful retrieval of sales data for the last 30 days and its accurate return in JSON format. Utilizing MockMvc for mocking API requests and Mockito for mocking the behaviors of OrderService and UserAuthValidator, the tests effectively simulate the operation of the actual service logic without the need for real data interactions.
- Update methods in SalesVolumeAPIController to use @GetMapping instead of default visibility - Define explicit endpoints for the last 30 days, last year, and last three years sales data - Ensure consistency and clarity in API route definitions
- Added tests for fetching sales data over the last year and the last three years - Utilized @WithMockUser to simulate authenticated user scenarios in tests - Adjusted date formatting to "yyyy-MM-dd" for consistent date handling - Ensured the setup of a mock user with ROLE_판매자 to test role-based access control
…ller - Implement a new GET endpoint to fetch sales data for the current day. - Import BigDecimal for handling precise sales calculations. - Ensure the functionality aligns with existing sales data retrieval patterns for consistency.
- Renamed test methods to better reflect their purpose and functionality - Added testFindSalesDataForCurrentDay() to test daily sales calculation - Updated existing tests to match changes in controller functionality - Improved code readability and removed redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.