Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge main into dev #305

Merged
merged 9 commits into from
Apr 19, 2024
Merged

chore: merge main into dev #305

merged 9 commits into from
Apr 19, 2024

Conversation

0xHansLee
Copy link
Contributor

@0xHansLee 0xHansLee commented Apr 18, 2024

There was a hotfix of changing Ecotone time to set odd timestampe for Kroma mainnet on main branch.
This PR includes the hotfix and to apply to dev branch.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Ecotone activation time to ensure accurate scheduling.

@0xHansLee 0xHansLee requested a review from a team April 18, 2024 04:30
Copy link
Contributor

coderabbitai bot commented Apr 18, 2024

Walkthrough

The update involves a minor change to the EcotoneTime value in the configuration settings of a blockchain node. The value has been incremented by one second, from 1713772800 to 1713772801. This adjustment affects the configuration files and their corresponding test files.

Changes

Files Change Summary
op-node/chaincfg/chains.go,
op-node/chaincfg/chains_test.go
Updated EcotoneTime from 1713772800 to 1713772801.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 1ba74f1 and 9445195.
Files selected for processing (2)
  • op-node/chaincfg/chains.go (1 hunks)
  • op-node/chaincfg/chains_test.go (1 hunks)
Additional comments not posted (2)
op-node/chaincfg/chains.go (1)

44-44: Update of EcotoneTime to 1713772801 is consistent with the PR objectives.

op-node/chaincfg/chains_test.go (1)

71-71: Update of EcotoneTime in test configuration to 1713772801 is consistent with the actual configuration changes.

Verification successful

The verification of the EcotoneTime update in the test configuration shows that the values are consistent with those in the actual configuration file. Both files contain two instances of EcotoneTime, each with the same values across the corresponding configurations. This suggests that the update is correctly implemented. However, it is recommended to ensure that these values are correctly associated with their respective configurations (e.g., mainnet, testnet).

  • chains.go and chains_test.go both have:
    • EcotoneTime: u64Ptr(1713772801)
    • EcotoneTime: u64Ptr(1713340800)
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify that the test configurations match the actual configurations for `EcotoneTime`.
rg --type go 'EcotoneTime' op-node/chaincfg/

Length of output: 342


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0xHansLee 0xHansLee merged commit 2b6cf4b into dev Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants