Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): implement 1-step undelegation for KGH #353

Merged
merged 25 commits into from
Jul 23, 2024
Merged

feat(contracts): implement 1-step undelegation for KGH #353

merged 25 commits into from
Jul 23, 2024

Conversation

0xHansLee
Copy link
Contributor

Implement 1-step undelegation for KGH (including batch)

@0xHansLee 0xHansLee self-assigned this Jul 19, 2024
@0xHansLee 0xHansLee requested a review from a team as a code owner July 19, 2024 10:20
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 19, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (2)
  • dev
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seolaoh
Copy link
Contributor

seolaoh commented Jul 22, 2024

Can you resolve compile errors in AssetManager?

sm-stack
sm-stack reviewed Jul 22, 2024
View reviewed changes
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated
boostedRewardsToReceive = kghAssetsToWithdraw - VKRO_PER_KGH * uint128(tokenIds.length);

vault.asset.totalKro -= kroAssetsToWithdraw;
vault.asset.totalKgh -= 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vault.asset.totalKgh -= 1;
vault.asset.totalKgh -= kghCount;

packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
seolaoh
seolaoh reviewed Jul 22, 2024
View reviewed changes
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/L1/AssetManager.sol Outdated Show resolved Hide resolved
0xHansLee added 2 commits July 22, 2024 17:11
0xHansLee added 2 commits July 22, 2024 18:29
feat(contracts): implement getKroAssets view func
6692470
Merge remote-tracking branch 'origin/feat/implement-validator-system-…
073e74f 
…v2' into feat/implement-1step-kro-undelegation

# Conflicts:
#	packages/contracts/contracts/L1/AssetManager.sol
seolaoh
seolaoh approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merge remote-tracking branch 'origin/feat/implement-1step-kro-undeleg…
d3c0020 
…ation' into feat/implement-1step-kgh-undelegation

# Conflicts:
#	packages/contracts/contracts/L1/AssetManager.sol
sm-stack
sm-stack approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@sm-stack sm-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/implement-1step-kro-undelegation to feat/implement-validator-system-v2 July 22, 2024 11:20
Merge remote-tracking branch 'origin/feat/implement-validator-system-…
0a0b65f 
…v2' into feat/implement-1step-kgh-undelegation

# Conflicts:
#	packages/contracts/contracts/L1/AssetManager.sol
@0xHansLee 0xHansLee merged commit e0f36b0 into feat/implement-validator-system-v2 Jul 23, 2024
1 of 2 checks passed
@0xHansLee 0xHansLee deleted the feat/implement-1step-kgh-undelegation branch July 23, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seolaoh seolaoh seolaoh approved these changes

@sm-stack sm-stack sm-stack approved these changes

Assignees

@0xHansLee 0xHansLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xHansLee @seolaoh @sm-stack