Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing .gitignore in the generated app #4

Closed
hankchiutw opened this issue Mar 30, 2021 · 5 comments
Closed

Missing .gitignore in the generated app #4

hankchiutw opened this issue Mar 30, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@hankchiutw
Copy link
Contributor

Reproduce

  • Do npm pack
  • tar zxvf create-krome-app-x.x.x.tgz
  • There should be a package/templates/_base/.gitignore, but not
@hankchiutw hankchiutw added the bug Something isn't working label Mar 30, 2021
@hankchiutw
Copy link
Contributor Author

npm still removes .gitignore: npm/npm#3763 (comment)

@hankchiutw
Copy link
Contributor Author

yarn pack/yarn publish could be an alternative, but needs fine-tune: yarnpkg/yarn#754

@hankchiutw
Copy link
Contributor Author

0546a6d

@hankchiutw
Copy link
Contributor Author

Still happens if using npx create-krome-app.
Here are two workarounds:

  • yarn create krome-app
  • yarn exec create-krome-app

@hankchiutw hankchiutw reopened this Apr 24, 2021
hankchiutw added a commit that referenced this issue Apr 24, 2021
@hankchiutw
docs: encourage using yarn exec instead of npx
718c7dc 
Because of `.gitignore` issue: #4
@hankchiutw
Copy link
Contributor Author

24da5e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hankchiutw