Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data-components,themes): add data components design tokens #760

Merged
merged 11 commits into from
Mar 15, 2024
Merged

feat(data-components,themes): add data components design tokens #760

merged 11 commits into from
Mar 15, 2024

Conversation

mmorin-equisoft
Copy link
Contributor

@mmorin-equisoft mmorin-equisoft changed the title feat(data-components,themes): add data components design tokens DS-979 feat(data-components,themes): add data components design tokens Mar 5, 2024
mmorin-equisoft
mmorin-equisoft commented Mar 5, 2024
View reviewed changes
packages/react/src/components/progress-indicator/bar.tsx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pareillement que pour circle.tsx

packages/react/src/components/progress-tracker/progress-tracker.tsx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai renommé les status en utilisant les valeurs défini dans Figma

packages/react/src/components/progress-circle/circle.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai déplacé le components interne Circle.
Il n'est pas exposé dans l'index et je doute qu'un component 'Circle' soit pertinent pour d'autres composants.
J'ai aussi bindé le token au progress-circle en nomant son token progress-circle-empty-stroke-color.

packages/react/src/components/progress-indicator/bar.tsx Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Storybook for this build: https://ds.equisoft.io/pr-760/

@mmorin-equisoft mmorin-equisoft marked this pull request as ready for review March 5, 2024 06:41
@mmorin-equisoft mmorin-equisoft requested a review from a team as a code owner March 5, 2024 06:41
hebernardEquisoft
hebernardEquisoft reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@hebernardEquisoft hebernardEquisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

packages/react/src/components/legend/legend.tsx Show resolved Hide resolved
packages/react/src/components/progress-tracker/progress-tracker.tsx Outdated Show resolved Hide resolved
packages/react/src/components/status/status.tsx Outdated Show resolved Hide resolved
hebernardEquisoft
hebernardEquisoft previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@hebernardEquisoft hebernardEquisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

LarryMatte
LarryMatte requested changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@LarryMatte LarryMatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un petit détail mais sinon LGTM
GJ

packages/react/src/components/progress-tracker/progress-tracker.tsx Outdated
} else {
dataTestId = 'progress-tracker-step-uncompleted';
screenReaderText = t('uncompletedAriaLabel');
StepComponent = UncompletedStep;
StepComponent = IncompleteStep;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu as changé Uncompleted pour Incompleted.
Selon le tableau plus bas, je crois que Uncompleted est plus approprié dans ce cas-ci.

Uncompleted Incompleted
Describes something not finished or accomplished Usually used in grammar or linguistics
Refers to tasks, projects, physical objects Refers to verbs or sentences missing required elements

J'ai été laisser un commentaire dans Figma pour faire la modification

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dans le même ordre idée, j'ai changé Complete pour Completed.
Si c'est bon, on pourrait l'ajouter à la note sur Figma.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la modification est fait dans Figma.
I thank you!

LarryMatte
LarryMatte previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@LarryMatte LarryMatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I'm concerned

savutsang
savutsang previously approved these changes Mar 12, 2024
View reviewed changes
hebernardEquisoft
hebernardEquisoft previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@hebernardEquisoft hebernardEquisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meriouma meriouma changed the title DS-979 feat(data-components,themes): add data components design tokens feat(data-components,themes): add data components design tokens Mar 15, 2024
@mmorin-equisoft mmorin-equisoft merged commit 307fdd0 into master Mar 15, 2024
20 checks passed
@mmorin-equisoft mmorin-equisoft deleted the dev/DS-979 branch March 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savutsang savutsang savutsang left review comments

@meriouma meriouma meriouma approved these changes

@hebernardEquisoft hebernardEquisoft hebernardEquisoft left review comments

@LarryMatte LarryMatte LarryMatte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmorin-equisoft @meriouma @savutsang @LarryMatte @hebernardEquisoft