-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude namespace queries to fetch container metric data #1309
Exclude namespace queries to fetch container metric data #1309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shekar also implemented similar filtering. Can't we create a common function and reference it statically?
Is it possible to design the metric profile with subsections to handle both namespace and container queries? In the future, we might need separate queries for different workloads, so it would be better to design the metric profile object with distinct and clear separations, rather than relying on 'startswith'.
Added a common function for filtering metrics in both the |
src/main/java/com/autotune/analyzer/recommendations/engine/RecommendationEngine.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shreyabiradar07 Any reason why we are not using |
@dinogun updated the function to filter metrics based on |
db5d401
to
2ba6ef1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR filters out
namespace queries
redundant
maxDate
query (already executed to fetch the interval start and end time before iterating through the list of metrics)to fetch container metric data to generate recommendations for a
container
based experiment to run only the relevant queries and not overload the datasource while running multiple experiments.Fixes #1308
Type of change
How has this been tested?
Tested by running local monitoring demos on ResourceHub cluster -
./local_monitoring_demo.sh -c openshift -i quay.io/shbirada/autotune_operator:filter-namespace-for-container-reco
pod logs with queries run for
tfb-server
andtfb-database
containers - https://privatebin.corp.redhat.com/?d50352a3d066c26b#4mGGpw7q2TXbrF1pN6C7yUykuphywPSwstMez2RkKWvBTest Configuration
Checklist 🎯
Additional information
docker image -
quay.io/shbirada/autotune_operator:filter-namespace-queries