Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds GPU queries to performance profile #1313

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

bharathappali
Copy link
Member

Description

This PR is a first's part of the set of PR's which will be raised for adding GPU support #1312

This PR adds the GPU queries to the performance profile YAML

Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Test coverage will be done in a separate PR

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on:

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

None

Signed-off-by: bharathappali <abharath@redhat.com>
@bharathappali
Copy link
Member Author

bharathappali commented Oct 3, 2024

@msvinaykumar @dinogun The namespace code is not changed I have just made an alignment change, Please view in the complete file view and let me know if any changes are needed.

@dinogun
Copy link
Contributor

dinogun commented Oct 3, 2024

@bharathappali Please update the JSON file as well for this. Also the non-recording rules versions of the files need to be updated as well

@dinogun
Copy link
Contributor

dinogun commented Oct 3, 2024

@kusumachalasani can you please review this

@bharathappali
Copy link
Member Author

Thanks for the review @dinogun Will make the necessary changes and update the PR

Signed-off-by: bharathappali <abharath@redhat.com>
@bharathappali
Copy link
Member Author

Added the changes your requested @dinogun . Please let me know if any other changes needed.

Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun
Copy link
Contributor

dinogun commented Oct 4, 2024

I'll merging this since this is the base PR on top of which all other GPU PRs are built on. However still need @kusumachalasani to sign off on this after she is back next week

@dinogun dinogun merged commit f709671 into kruize:mvp_demo Oct 4, 2024
2 of 3 checks passed
@kusumachalasani
Copy link
Contributor

kusumachalasani commented Oct 7, 2024

@bharathappali As the current GPU queries doesn't differentiate the GPU Usage for the same container name in two different workloads (job, deployment) in a namespace - it would be worth gathering the metrics at pod level and group them with workload queries to aggregate the actual usage. Similar to what we planned for container level local monitoring queries.

@bharathappali
Copy link
Member Author

@kusumachalasani Thanks for the review. Will make those changes and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants