-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds GPU queries to performance profile #1313
Conversation
Signed-off-by: bharathappali <abharath@redhat.com>
@msvinaykumar @dinogun The namespace code is not changed I have just made an alignment change, Please view in the complete file view and let me know if any changes are needed. |
@bharathappali Please update the JSON file as well for this. Also the non-recording rules versions of the files need to be updated as well |
@kusumachalasani can you please review this |
Thanks for the review @dinogun Will make the necessary changes and update the PR |
Signed-off-by: bharathappali <abharath@redhat.com>
Added the changes your requested @dinogun . Please let me know if any other changes needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll merging this since this is the base PR on top of which all other GPU PRs are built on. However still need @kusumachalasani to sign off on this after she is back next week |
@bharathappali As the current GPU queries doesn't differentiate the GPU Usage for the same container name in two different workloads (job, deployment) in a namespace - it would be worth gathering the metrics at pod level and group them with workload queries to aggregate the actual usage. Similar to what we planned for container level local monitoring queries. |
@kusumachalasani Thanks for the review. Will make those changes and get back to you. |
Description
This PR is a first's part of the set of PR's which will be raised for adding GPU support #1312
This PR adds the GPU queries to the performance profile YAML
Fixes # (issue)
Type of change
How has this been tested?
Test coverage will be done in a separate PR
Test Configuration
Checklist 🎯
Additional information
None