Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulkupdateresults #894

Merged
merged 61 commits into from
Aug 17, 2023
Merged

Bulkupdateresults #894

merged 61 commits into from
Aug 17, 2023

Conversation

msvinaykumar
Copy link
Contributor

No description provided.

@msvinaykumar msvinaykumar force-pushed the bulkupdateresults branch 2 times, most recently from 5dac7f8 to aded5b5 Compare July 21, 2023 09:21
@msvinaykumar msvinaykumar self-assigned this Jul 25, 2023
@msvinaykumar msvinaykumar added the analyzer Analyzer module related issues label Jul 25, 2023
@msvinaykumar msvinaykumar added this to the Kruize 0.0.18_lm Release milestone Jul 25, 2023
This was linked to issues Jul 25, 2023
[Scalability] - Using UpdateRecomm API optimize code to handle horizontal scaling of pods #815
Closed
New API 'UpdateRecommendations' to support non-chronological order of data #816
Closed
@msvinaykumar msvinaykumar force-pushed the bulkupdateresults branch 3 times, most recently from baa6248 to cb7914c Compare August 12, 2023 18:53
msvinaykumar and others added 20 commits August 16, 2023 19:10
@msvinaykumar
In progress code checked in for updateRecommendation API.
0410e12 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Taking care of duplicate entry to recommendation table
521f161 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateResults API optimized.
a56c5c1 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
resolved conflicts
3ab5e1f 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Moved logic to select results into perfProfiles.
b152858 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Date range update recommendations are handled
a5c528c 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
In progress code checked in for updateRecommendation API.
86ac1d1 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
endDate is not mandatory
7a0b5a7 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
resolved conflicts
3be9c1b 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
In progress code checked in for updateRecommendation API.
886b435 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Taking care of duplicate entry to recommendation table
6581ea0 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
In progress code checked in for updateRecommendation API.
79fac3c 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@khansaad @msvinaykumar
add changes for the performance profile table addition in the DB
52ffa53 
Signed-off-by: saakhan <saakhan@redhat.com>
@khansaad @msvinaykumar
update service methods for performance profiles
1c58657 
Signed-off-by: saakhan <saakhan@redhat.com>
@khansaad @msvinaykumar
fix issue with the sloData not getting populated and other minor changes
40a7099 
Signed-off-by: saakhan <saakhan@redhat.com>
@msvinaykumar
In progress code checked in for updateRecommendation API.
e55c51a 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
42477dd 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Added exception conditions.
a897c68 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Taking care of duplicate entry to recommendation table
eb1e941 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Date range update recommendations are handled
e59e21d 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
2e70475 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Added exception conditions.
26af430 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
To restrict the number of rows in the result set, the Load results op…
e8b7c3c 
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
endDate is not mandatory
2dfc303 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
In progress code checked in for updateRecommendation API.
57b33cd 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
eee8dbc 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Added exception conditions.
0f91741 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
To restrict the number of rows in the result set, the Load results op…
c053761 
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Merging confilts
801835c 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Taking care of duplicate entry to recommendation table
6b787d2 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
resolving conflicts
b4ca2b6 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Moved logic to select results into perfProfiles.
198417f 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
7ab4fee 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Added exception conditions.
e9873e9 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
To restrict the number of rows in the result set, the Load results op…
209e8f1 
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Taking care of duplicate entry to recommendation table
9dbb7da 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateResults API optimized.
59d6cd5 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
In progress code checked in for updateRecommendation API.
0da8d1f 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
a9785e1 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
To restrict the number of rows in the result set, the Load results op…
0b8e39b 
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Merging confilts
9be2841 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Taking care of duplicate entry to recommendation table
676de21 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
restricted http request thread to 6
d707612 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
resolved conflicts
c78abeb 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
tested hole in results for already updated recommendations fix
f5090a9 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
merged Conflicts
c5fb5e2 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
resolved conflicts
0d82ace 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
dinogun
dinogun approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like how the verification and validators code has been written. Makes it easy to trace validation issues and segregate them!

@dinogun dinogun merged commit 67f3e7f into kruize:mvp_demo Aug 17, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinogun dinogun dinogun approved these changes

Assignees

@msvinaykumar msvinaykumar

Labels
analyzer Analyzer module related issues
Projects
Monitoring
Status: Done
Milestone
Kruize 0.0.18_lm Release
3 participants
@msvinaykumar @dinogun @khansaad