Rename duration based to cost #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinogun
reviewed
Aug 17, 2023
Comment on lines
282
to
286
| Double memRecUsage = CommonUtils.percentile(NINETY_FIFTH_PERCENTILE, memUsageList); | ||
| Double memRecUsageBuf = memRecUsage + (memRecUsage * MEM_USAGE_BUFFER_DECIMAL); | ||
|
|
||
| // Add a small buffer to the current usage spike max and add it to the current usage max | ||
| Double memRecSpike = CommonUtils.percentile(HUNDREDTH_PERCENTILE, spikeList); | ||
| Double memRecSpike = CommonUtils.percentile(NINETY_FIFTH_PERCENTILE, spikeList); |
There was a problem hiding this comment.
Please keep the memory calculations the same as before. Lowering Memory usage might cause the app to crash. Lowering CPU will only cause the app to stall.
There was a problem hiding this comment.
Reverted the memory value to have 100th percentile
dinogun
reviewed
Aug 17, 2023
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Merged
Signed-off-by: bharathappali <abharath@redhat.com>
bharathappali
force-pushed
the
rename-duration-based-to-cost
branch
from
e4374c5
to
0e590e5
Compare
rbadagandi1
modified the milestones:
Kruize 0.0.19_rm Release,
Kruize 0.0.20_rm Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the duration based engine to cost
Also makes the engine to use 95th percentile for CPU and memory to give out the recommendations