Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest=false fixed the code #913

Merged
merged 4 commits into from
Aug 23, 2023
Merged

latest=false fixed the code #913

merged 4 commits into from
Aug 23, 2023

Conversation

msvinaykumar
Copy link
Contributor 

/**
         * Identify timestamps that exhibit the "NOT_ENOUGH_DATA" status
         * for all three categories: short, medium, and long etc. Subsequently,
         * eliminate these timestamps from the k8sObject to prevent the data from being stored in the database.
         * As a result, when using the query parameter "listRecommendation?latest=false,"
         * only a collection of viable recommendations will be displayed
         */

@msvinaykumar
latest=false fixed the code
18a9154 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar msvinaykumar self-assigned this Aug 23, 2023
@msvinaykumar msvinaykumar added the bug Something isn't working label Aug 23, 2023
@msvinaykumar msvinaykumar added this to the Kruize 0.0.18_rm Release milestone Aug 23, 2023
@msvinaykumar msvinaykumar linked an issue Aug 23, 2023 that may be closed by this pull request
New API 'UpdateRecommendations' to support non-chronological order of data #816
Closed
@msvinaykumar
moved logic to recommendation
abeffdf 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Removed range for updateRecommednationApi
f01b97e 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
incorporated review comments
402f7a2 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
dinogun
dinogun approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest changes now looking much better. Approving

@dinogun dinogun merged commit f1183eb into kruize:mvp_demo Aug 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinogun dinogun dinogun approved these changes

Assignees

@msvinaykumar msvinaykumar

Labels
bug Something isn't working
Projects
Monitoring
Status: Done
Milestone
Kruize 0.0.18_rm Release
Development

Successfully merging this pull request may close these issues.

New API 'UpdateRecommendations' to support non-chronological order of data
2 participants
@msvinaykumar @dinogun