Фикс шаблонов #238
Merged
Фикс шаблонов #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L140-beep
force-pushed
the
meta-editor
branch
2 times, most recently
from
f22d432 to
aa6ce9f
Compare
chekoopa
requested changes
Mar 19, 2024
| let stringMeta = ''; | ||
| for (const propName in meta) { | ||
| const property = meta[propName]; | ||
| stringMeta += `${propName}/ ${property}\n`; |
There was a problem hiding this comment.
Можно переписать лаконичнее с использованием этого:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/join
Есть опасение про многострочные значения и экранирование слеша.
chekoopa
approved these changes
Mar 21, 2024
L140-beep
added a commit
to L140-beep/lapki-client
that referenced
this pull request
Mar 23, 2024
chekoopa
pushed a commit
that referenced
this pull request
Apr 15, 2024
* condition building * remove unused imports * operatorAlias to object * Фикс переходов в шаблонах (#238) * fix issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавление id у переходов в шаблоны