Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Поддержка MacOS #252

Merged
merged 11 commits into from
May 5, 2024
Merged

Поддержка MacOS #252

merged 11 commits into from
May 5, 2024

Conversation

Roundabout1
Copy link
Contributor

  • Исполняемый файл загрузчика для MacOS
  • Изменения в клиенте для обеспечения работы загрузчика на MacOS

@Roundabout1
Copy link
Contributor Author

Roundabout1 commented May 5, 2024 •
edited
Loading

Возможно понадобиться дополнить README с инструкциями (что делать если система безопасности macOS не даёт запустить клиент, как установить avrdude на macOS). Пример инструкции: https://notes.polyus-nt.ru/doc/lapki-ide-i-zagruzchik-na-macos-VW7DzoGwW5

@Roundabout1 Roundabout1 marked this pull request as ready for review May 5, 2024 09:27
chekoopa
chekoopa requested changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@chekoopa chekoopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Долгожданное. Опечатку исправь, и можно будет мержить.

src/main/modules/ModuleManager.ts Outdated
// позволяет унаследовать $PATH, то есть системный путь
// это нужно для того, чтобы загрузчик смог получить доступ к avrdude, если путь к нему прописан в $PATH
fixPath();
// break не нужен, так как дальнейшие действия одинаковы для Lunix и macOS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux же!

@chekoopa
Copy link
Collaborator

chekoopa commented May 5, 2024

В README.md можно добавить эту ссылку:

https://github.com/kruzhok-team/lapki-client/wiki/%D0%9C%D0%BE%D0%B4%D1%83%D0%BB%D1%8C-%D0%B7%D0%B0%D0%B3%D1%80%D1%83%D0%B7%D1%87%D0%B8%D0%BA%D0%B0-%D0%BD%D0%B0-macOS

@chekoopa chekoopa merged commit e0341d5 into kruzhok-team:main May 5, 2024
1 check passed
@Roundabout1 Roundabout1 deleted the darwin branch May 7, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chekoopa chekoopa chekoopa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roundabout1 @chekoopa