Skip to content

Commit

Permalink
deps: hide zlib internal symbols
Browse files Browse the repository at this point in the history
Use HAVE_HIDDEN when compiling zlib so it's internal symbols
have __attribute__((visibility ("hidden"))).

PR-URL: nodejs#11082
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
  • Loading branch information
sam-github authored and krydos committed Feb 25, 2017
1 parent 58dc229 commit aa20597
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deps/zlib/zlib.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
'conditions': [
['OS!="win"', {
'cflags!': [ '-ansi' ],
'defines': [ 'Z_HAVE_UNISTD_H' ],
'defines': [ 'Z_HAVE_UNISTD_H', 'HAVE_HIDDEN' ],
}],
['OS=="mac" or OS=="ios" or OS=="freebsd" or OS=="android"', {
# Mac, Android and the BSDs don't have fopen64, ftello64, or
Expand Down

0 comments on commit aa20597

Please sign in to comment.