Pie %n tooltip template shows total number represented by a pie slice #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I trust that your code is up to snuff, but I would still like to review the code before merging. I should have time to do it after work tomorrow! |
|
Thanks. I have a fix for the %ct problem worked out too, but it looks to me like submitting two pull requests for .js code at the same time would cause trouble, since the grunted, minified code would be hard to merge. Is that the case? If so, I'll just make the pull requests more slowly and sequentially. |
Roundaround
added a commit
that referenced
this pull request
Jun 6, 2015
Pie %n tooltip template shows total number represented by a pie slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the js/jquery.flot.tooltip.source.js to add a '%n' replacement template available in pie charts. Under the previous tooltip templates, it was possible to get a percentage to show in the tooltip, but not the total number (N) of items/instances/etc represented by that segment of the pie chart. This addition adds the %n template to the javascript source code as well as a demo in the examples/pie.html file.