Improved Logging/Error Handling during SwiftTemplate Processing #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added more logs for time measurement in SwiftTemplate; added a note how exactly cacheKey is calculated and it's intended usage; added possibility to pass Log configuration when using SourceryLib instead of executable for logging setup.
art-divin
commented
Mar 30, 2024
| do { | ||
| try build().move(binaryPath) | ||
| } catch let error as NSError { | ||
| if error.domain == "NSCocoaErrorDomain", error.code == 516 { |
There was a problem hiding this comment.
This is what now allows to execute Sourcery from multiple processes in parallel, generating code into different directories when swifttemplate is shared across these executions (i.e. cached and reused).
art-divin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses the fact that when executing Sourcery from multiple processes (i.e. running
sourceryexecutable from other scripts), mock generation fails ifcacheBasePathis the same between these concurrent processes.In actuality, the only reason the
swifttemplateprocessing fails is because one process is trying to cacheSwiftTemplatebinary in parallel with another process doing the same for the same SwiftTemplate, i.e. whencacheKeyis exactly the same between these executables.Description
This PR does the following: