Skip to content
This repository has been archived by the owner on Mar 25, 2020. It is now read-only.

Force HTTPS #102

Closed
nodomain opened this issue Feb 25, 2018 · 1 comment · Fixed by #104
Closed

Force HTTPS #102

nodomain opened this issue Feb 25, 2018 · 1 comment · Fixed by #104
Labels
good first issue
Milestone
v0.6.2

Comments

@nodomain
Copy link
Contributor

Awesome product!

I would like to see a "force HTTPs" option, e.g. that the CloudFront behavior by default is set to redirect HTTP to HTTPS. Would you please implement or give me a hint where to "fix" this? Newbie to Cloudformation...
@ks888
Copy link
Owner

ks888 commented Feb 26, 2018

Sounds good! I think we can always redirect http to https and don't need to make it optional as I assume our status page supports https access in any case.

Also, thank you for offering your help. Our cloudformation template file is ./cloudformation/lamb-status.yml and maybe just modifying some properties of the AWS::CloudFront::Distribution resource is enough. There are some ViewerProtocolPolicy properties and so change these values seeing this doc.

nodomain added a commit to nodomain/LambStatus that referenced this issue Mar 5, 2018
@nodomain
Updated to redirect any HTTP request to HTTPS. Fixes ks888#102
e9d2369 
This should fix ks888#102 where I suggested to use HTTPS only.
@nodomain nodomain mentioned this issue Mar 5, 2018
Merged
@ks888 ks888 closed this as completed in #104 Mar 6, 2018
ks888 added a commit that referenced this issue Mar 6, 2018
@ks888
Merge pull request #104 from nodomain/patch-1
e845171 
Updated to redirect any HTTP request to HTTPS. Fixes #102
@ks888 ks888 added this to the v0.6.2 milestone Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
v0.6.2
Development

Successfully merging a pull request may close this issue.

Updated to redirect any HTTP request to HTTPS. Fixes #102 nodomain/LambStatus
2 participants
@nodomain @ks888