Get rid of add_to_hits_per_ref() min_diff parameter #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has no effect
|
approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this parameter is to disallow hits that span too different lengths on the query compared to the reference.
The parameter has a bit of a misleading name because it is actually the maximum allowed difference. (This can come from some of my refactoring. Within the function, it represents the minimum observed difference so far. The value provided as argument is merely its initial value.)
But mainly, the parameter has no effect at all and just initializing it to
std::numeric_limits<int>::max()leads to the same decisions being made. (I temporarily added some code tested this.)