Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up NAM merging a bit #336

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Speed up NAM merging a bit #336

merged 6 commits into from
Sep 6, 2023

Commits on Sep 5, 2023

  1. Keep forward and reverse hits separate

    merge_hits_into_nams() has a nested for loop that iterates over a vector
    that contains both forward and reverse hits, but it also has an extra check
    to ensure that it never merges forward and reverse hits into NAMs. We can
    instead keep forward and reverse hits separate when we generate them and
    then work on them separately.
    marcelm committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5d7a16f View commit details
    Browse the repository at this point in the history
  2. Get rid of Hits::is_rc

    Whether a Hit is a forward or reverse hit is known implicitly because
    forward and reverse hits are stored in two different unordered_maps.
    marcelm committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b403942 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91f2223 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Update baseline commit

    marcelm committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    770683f View commit details
    Browse the repository at this point in the history
  2. Fix compilation on macOS

    marcelm committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    47f8f36 View commit details
    Browse the repository at this point in the history
  3. Remove RescueHit::is_rc

    marcelm committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    15c8466 View commit details
    Browse the repository at this point in the history