Os type check seems wrong #356
Comments
|
Sorry for inconvenience. Could you submit a PR to the 4.1 branch? |
|
@holgerbrandl Sure |
justixLoL
pushed a commit
to justixLoL/kscript
that referenced
this issue
May 20, 2022
aartiPl
pushed a commit
that referenced
this issue
May 20, 2022
bugfix: issue #356 - fix ostype comparison Co-authored-by: holgerbrandl@gmail.com <holgerbrandl@users.noreply.github.com> Co-authored-by: Aleksandr Kolodiazhnyi <akolodyazhni@Aleksandrs-MBP.localdomain>
|
I have backported it also to the master branch. In fact, I think that Mac is reporting OSTYPE incorrectly - it should contain only single information about the type of OS, not a specific version or any additional information. Maybe we can wait a bit if something pops up, and if not - do another bugfix release. |
|
Should be fixed in 4.0.3 - please reopen if the problem persists... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Holger,
It seems that comparison of current os should be changed from
equalstocontains:Cause on version 4.0.2 I get the error
[kscript] [ERROR] Unsupported OS: darwin21because 'darwin' in your enum != 'darwin21'On version 4.0.0 all is good
The text was updated successfully, but these errors were encountered: