{AzureNetwork} fixes Azure#22448 Making priority required (Azure#22874)

* {AzureNetwork} fixes Azure#22448 Making priority required fixes Azure#22448 [This is the API](https://learn.microsoft.com/en-us/rest/api/virtualnetwork/network-security-groups/create-or-update?tabs=HTTP#code-try-0) I invoked. For the NSG security rules without priorities, seems like the priority parameter is required. Azure portal works as expected. I don't think that's allowed but according to the schema it is because the priority property is not marked as required. I tried to create a NSG security rule without the priorities and it failed with below. Intrestingly the Azure Request Body: ``` { "properties": { "securityRules": [ { "name": "rule1", "properties": { "protocol": "*", "sourceAddressPrefix": "*", "destinationAddressPrefix": "*", "access": "Allow", "destinationPortRange": "80", "sourcePortRange": "*", "direction": "Inbound" } } ] }, "location": "eastus" } ``` Response received: ``` { "error": { "code": "SecurityRuleInvalidPriority", "message": "Security rule has invalid Priority. Value provided: 0 Allowed range 100-4096.", "details": [] } } ``` This PR will make the priority parameter as required. * Update NetworkSecurityGroupRuleDelete.json Long running operation should return `azure-AsyncOperation` in response header. * Update NetworkSecurityGroupDelete.json Long running operation should return location or azure-AsyncOperation in header. * Update NetworkSecurityGroupRuleDelete.json * Update NetworkSecurityGroupDelete.json * Update NetworkSecurityGroupRuleDelete.json * Update NetworkSecurityGroupDelete.json
kseager · Mar 17, 2023 · af6c7cb · af6c7cb
1 parent f65b3ca
commit af6c7cb
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/...urce-manager/Microsoft.Network/stable/2022-09-01/examples/NetworkSecurityGroupDelete.json b/...urce-manager/Microsoft.Network/stable/2022-09-01/examples/NetworkSecurityGroupDelete.json
@@ -7,7 +7,17 @@
   },
   "responses": {
     "200": {},
-    "202": {},
-    "204": {}
+    "202": {
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2022-09-01",
+        "Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/locations/eastus/operations/00000000-0000-0000-0000-000000000000?api-version=2022-09-01"
+      }
+    },
+    "204": {
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2022-09-01",
+        "Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/locations/eastus/operations/00000000-0000-0000-0000-000000000000?api-version=2022-09-01"
+      }
+    }
   }
 }
diff --git a/...-manager/Microsoft.Network/stable/2022-09-01/examples/NetworkSecurityGroupRuleDelete.json b/...-manager/Microsoft.Network/stable/2022-09-01/examples/NetworkSecurityGroupRuleDelete.json
@@ -7,8 +7,16 @@
     "securityRuleName": "rule1"
   },
   "responses": {
-    "200": {},
-    "202": {},
+    "200": {
+      "headers": {
+        "Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/locations/eastus/operations/00000000-0000-0000-0000-000000000000?api-version=2022-09-01"
+      }
+    },
+    "202": {
+      "headers": {
+        "Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/locations/eastus/operations/00000000-0000-0000-0000-000000000000?api-version=2022-09-01"
+      }
+    },
     "204": {}
   }
 }
diff --git a/...on/network/resource-manager/Microsoft.Network/stable/2022-09-01/networkSecurityGroup.json b/...on/network/resource-manager/Microsoft.Network/stable/2022-09-01/networkSecurityGroup.json
@@ -820,6 +820,7 @@
       "required": [
         "protocol",
         "access",
+        "priority",
         "direction"
       ],
       "description": "Security rule resource."