Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RawDeployment support for Inference Graph #3194

Merged
merged 15 commits into from
Oct 24, 2023
Merged

Conversation

bmopuri
Copy link
Contributor

@bmopuri bmopuri commented Oct 20, 2023

What this PR does / why we need it:
This change is to bring RawDeployment to Inference graph. Currently Inference Services support raw deployment, this changes brings parity.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
#2454

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


@rachitchauhan43
Copy link
Contributor

@bmopuri : Can you fix the DCO check ?

@rachitchauhan43
Copy link
Contributor

rachitchauhan43 commented Oct 24, 2023

@yuzisun : I added a lgtm label to trigger tests. Tests are not getting triggered :
Screenshot 2023-10-23 at 5 25 40 PM

@kserve-oss-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: bmopuri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Mopuri, Bharath and others added 15 commits October 23, 2023 18:22
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Mopuri, Bharath <bharath_mopuri@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
Signed-off-by: Tanvi Thakur <tanvi_thakur@intuit.com>
@kserve-oss-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@kserve-oss-bot kserve-oss-bot merged commit 1b16899 into kserve:master Oct 24, 2023
2 checks passed
rachitchauhan43 added a commit to rachitchauhan43/kserve that referenced this pull request Oct 24, 2023
kserve-oss-bot pushed a commit that referenced this pull request Oct 24, 2023
Revert "RawDeployment support for Inference Graph (#3194)"

This reverts commit 1b16899.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants