fix: Check if HPA has the same scaleTargetRef and behavior #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrytangyuan
force-pushed
the
check-scale-target-ref
branch
from
81e8c07 to
e612fba
Compare
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
force-pushed
the
check-scale-target-ref
branch
from
e612fba to
fbfe996
Compare
Jooho
reviewed
Dec 13, 2023
pkg/controller/v1beta1/inferenceservice/reconcilers/hpa/hpa_reconciler.go
Outdated
Show resolved
Hide resolved
…conciler.go Co-authored-by: Jooho Lee <ljhiyh@gmail.com> Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
changed the title
|
@Jooho Great suggestion. Added check for behavior as well! |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@yuzisun Thanks for the review. Just updated the PR to check spec directly. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There maybe existing HPAs but incorrectly configured to target non-deployment resources. This PR adds additional check on scaleTargetRef.