feat: Automatically generate Helm Chart docs. Fixes #3356 #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrytangyuan
commented
Jan 14, 2024
There was a problem hiding this comment.
This is intentionally empty to make helm-docs happy
| @@ -0,0 +1,18 @@ | |||
| {{ template "chart.header" . }} | |||
There was a problem hiding this comment.
These gotmpl files are used to add custom installation instructions
|
TODOs once this is merged:
|
|
/assign @yuzisun |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
timothyjlaurent
pushed a commit
to timothyjlaurent/kserve
that referenced
this pull request
Feb 21, 2024
…ve#3363) * generate docs Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3356.
Steps:
pre-commit install; pre-commit run --allorgit commitonce pre-commit hook is installed.