Fix bug: Remove redundant helm chart affinity on predictor CRD #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labels: - app.kubernetes.io/managed-by - app.kubernetes.io/instance - app.kubernetes.io/name: with value modelmesh-controller cause affinity to non existent helm chart Signed-off-by: Ondrej Trojan <26576371+trojaond@users.noreply.github.com>
trojaond
changed the title
|
/assign @rachitchauhan43 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan, trojaond, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tjandy98
pushed a commit
to tjandy98/kserve
that referenced
this pull request
Apr 10, 2024
…e#3481) Remove redundant helm chart affinity labels: - app.kubernetes.io/managed-by - app.kubernetes.io/instance - app.kubernetes.io/name: with value modelmesh-controller cause affinity to non existent helm chart Signed-off-by: Ondrej Trojan <26576371+trojaond@users.noreply.github.com> Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels:
with value modelmesh-controller cause affinity to non existent helm chart
What this PR does / why we need it:
When you deploy the crd with helm (or through argocd/fluxdb) the labels on this predictor CRD are making the CRD shared with non existent helm chart. It adds warning message.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
When helm is applied SharedResourceWarning with message:
CustomResourceDefinition/predictors.serving.kserve.io is part of applications argocd/kserve and modelmesh-controller
is not there
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: