Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable image pull secrets in Helm charts #3838

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

saileshd1402
Copy link
Contributor

@saileshd1402 saileshd1402 commented Aug 2, 2024

What this PR does / why we need it:
This PR adds configurable images pull secrets for kserve controller and serving runtimes from Helm charts.

Currently, to add image pull secrets for images in Helm installations, we will have to patch the secrets after deploying the helm charts. With this change we can add it through the Helm command itself.

Example of configuring image pull secrets for kserve controller:

helm install kserve charts/kserve-resources/ --set kserve.controller.imagePullSecrets[0].name=kserve-controller-secret

Example of configuring image pull secrets for cluster serving runtime (huggingfaceserver):

helm install kserve charts/kserve-resources/ --set kserve.servingruntime.huggingfaceserver.imagePullSecrets[0].name=huggingface-secret

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

Signed-off-by: sailesh.duddupudi@nutanix.com <sailesh.duddupudi@nutanix.com>
Signed-off-by: sailesh.duddupudi@nutanix.com <sailesh.duddupudi@nutanix.com>
@saileshd1402
Copy link
Contributor Author

Hi @yuzisun, I wanted your thoughts on this PR. We think it'll helpful during helm installations for image pull secrets to be customisable. I think this PR is ready for review, please let me know if there are any other changes to be made.

@saileshd1402
Copy link
Contributor Author

Hi, @terrytangyuan, I wanted your thoughts on this PR, and if you think any changes are necessary.
cc: @johnugeorge

Copy link
Member

@yuzisun yuzisun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@yuzisun yuzisun merged commit c10f548 into kserve:master Aug 24, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants