Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf version upgrade 4.25.4 #3881

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

andyi2it
Copy link
Contributor

What this PR does / why we need it:
Temporarily upgrades protobuf to 4.25.4 and once Kubeflow starts supporting 5.x then we will migrate
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3730

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing:

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:

NONE

Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@andyi2it andyi2it force-pushed the protobuf-version-bump-4.25.4 branch from ba91c27 to 7aa83ed Compare August 21, 2024 11:44
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
@andyi2it
Copy link
Contributor Author

/rerun-all

2 similar comments
@andyi2it
Copy link
Contributor Author

/rerun-all

@andyi2it
Copy link
Contributor Author

/rerun-all

Copy link
Member

@yuzisun yuzisun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@yuzisun yuzisun merged commit 0a6302b into kserve:master Aug 24, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python SDK for KServe and Kubeflow Pipelines can not be installed at the same time
2 participants