fix: Propagate context to puller download tasks #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation For some reason, the loadModel context is not passed via the puller's ProcessLoadModelRequest function to pullman's Pull function. This means that storage downloads won't be cancelled when the corresponding request is cancelled or times out. Modifications Add a Context argument to the puller's ProcessLoadModelRequest function, use in the call to pull manager's Pull instead of context.TODO(). Result In-progress model downloads from shared storage downloads will be cancelled when the corresponding request is cancelled or times out. Signed-off-by: Nick Hill <nickhill@us.ibm.com>
tjohnson31415
approved these changes
Sep 2, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhill, tjohnson31415 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For some reason, the
LoadModelcontext is not passed via the puller'sProcessLoadModelRequestfunction to pullman'sPullfunction. This means that storage downloads won't be cancelled when the corresponding request is cancelled or times out.Modifications
Add a
Contextargument to the puller'sProcessLoadModelRequestfunction, use in the call to pull manager'sPullinstead ofcontext.TODO().Result
In-progress model downloads from shared storage downloads will be cancelled when the corresponding request is cancelled or times out.