Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push multi-arch images #38

Merged
merged 33 commits into from
May 5, 2023
Merged

Push multi-arch images #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
3e15253
Push multi-arch images
ddelange Jan 16, 2023
4ec696f
Add --target runtime
ddelange Jan 16, 2023
2cdff97
Build not push on PR
ddelange Jan 16, 2023
77915da
Merge branch 'main' into patch-1
ckadner Mar 30, 2023
d682165
Update Dockerfile to use platform args
ckadner Mar 31, 2023
ad0b945
prettier
ckadner Mar 31, 2023
d7d2609
tensorflow not available on s390x
ckadner Mar 31, 2023
a592fc7
build platform linux/amd64
ckadner Mar 31, 2023
711af70
build platform linux/arm64
ckadner Mar 31, 2023
c4e8e4e
build platform linux/ppc64le
ckadner Mar 31, 2023
a2c7c2f
build platform linux/s390x
ckadner Mar 31, 2023
a0707f9
Cross-compile build stage
ckadner Apr 4, 2023
bb7a32e
Upgrade UBI to v8.7; exclude s390x
ckadner Apr 4, 2023
97f9ded
tensorflow not available on ppc64le
ckadner Apr 4, 2023
5ff67a8
Build dev image for BUILDPLATFORM only
ckadner Apr 4, 2023
e26aae4
Install grpcio using wheel before tensorflow
ckadner Apr 5, 2023
44dd08d
cache microdnf install packages
ckadner Apr 5, 2023
c2ee7d4
Don't set "default" for ARG TARGETOS and ARG TARGETARCH
ckadner Apr 12, 2023
f671a1f
Build developer image for all platforms
ckadner Apr 12, 2023
2d269a7
Use buildkit for unit-test
ckadner Apr 12, 2023
899841f
lint
ckadner Apr 12, 2023
5d6dc87
pre-build dev image for build platform only
ckadner Apr 12, 2023
e42267f
Build dev image for build platform only
ckadner Apr 12, 2023
c163d06
Address pip cache disabled warning
ckadner Apr 12, 2023
34aed5c
Test image layer caching
ckadner Apr 12, 2023
035c4d6
Use PIP_CACHE_DIR
ckadner Apr 12, 2023
66a483f
Use PIP_CACHE_DIR to install pre-commit
ckadner Apr 12, 2023
0026153
Address review comments
ckadner Apr 27, 2023
007b94d
Merge branch 'main' into patch-1
ckadner Apr 28, 2023
77fc304
Missing newline at end of file .dockerignore
ckadner Apr 28, 2023
6d150ad
Use ENV instead of ARG for non-build-args
ckadner May 4, 2023
78e7ee4
Mark .PHONY make targets separately
ckadner May 4, 2023
c03aa77
Harmonize GitHub workflow files
ckadner May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-and-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ jobs:
- name: Build and push runtime image
uses: docker/build-push-action@v4
with:
platforms: linux/amd64,linux/arm64,linux/ppc64le,linux/s390x
# tensorflow not supported for s390x architecture https://github.com/tensorflow/tensorflow/issues/46181
platforms: linux/amd64,linux/arm64,linux/ppc64le #,linux/s390x
ckadner marked this conversation as resolved.
Show resolved Hide resolved
context: .
target: runtime
push: ${{ github.event_name != 'pull_request' }}
Expand Down
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ LABEL name="model-serving-runtime-adapter" \
description="Container which runs in each model serving pod and act as an intermediary between model-mesh and third-party model-server containers"

USER root

# install python to convert keras to tf
# NOTE: tensorflow not supported for s390x architecture https://github.com/tensorflow/tensorflow/issues/46181
RUN microdnf install \
gcc \
gcc-c++ \
Expand Down