Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build all binaries for the target OS/ARCH #49

Merged
merged 1 commit into from
May 15, 2023
Merged

fix: build all binaries for the target OS/ARCH #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ ARG TARGETARCH
# https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/
RUN --mount=type=cache,target=/root/.cache/go-build \
--mount=type=cache,target=/go/pkg \
GOOS=${TARGETOS:-linux} \
GOARCH=${TARGETARCH:-amd64} \
export GOOS=${TARGETOS:-linux} && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjohnson31415 -- I know I missed the review window on this one, but would it not have been more Docker-esque to pull the two variables out into a Dockerfile ENV declaration?

ENV GOOS=${TARGETOS:-linux} \
    GOARCH=${TARGETARCH:-amd64}
RUN --mount=... \
    go build -o ...

Only RUN, COPY, and ADD create layers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, these two environment variables are configurations only for the single RUN command. If this docker stage was FROM'd in a final pushed image, I'd think it better avoid the extra env vars created by ENV, but this is an intermediate stage so 🤷

export GOARCH=${TARGETARCH:-amd64} && \
go build -o puller model-serving-puller/main.go && \
go build -o triton-adapter model-mesh-triton-adapter/main.go && \
go build -o mlserver-adapter model-mesh-mlserver-adapter/main.go && \
Expand Down